Skip to content

Skip 3 localization tests #13118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Skip 3 localization tests #13118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/test/unit/System.Windows.Forms/System/Windows/Forms/KeysConverterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ public void ConvertFrom_ShouldConvertKeys(string input, Keys keys)
Assert.Equal(keys, result);
}

[Theory]
[ActiveIssue("https://github.com/dotnet/winforms/issues/13117")]
[Theory(Skip = "Localization tests, see: https://github.com/dotnet/winforms/issues/13117")]
[InlineData("fr-FR", "(aucun)", Keys.None)]
[InlineData("nb-NO", "None", Keys.None)]
[InlineData("de-DE", "Ende", Keys.End)]
Expand Down Expand Up @@ -71,7 +72,8 @@ public void ConvertToString_ShouldConvertKeys(Keys keys, string expectedResult)
Assert.Equal(expectedResult, result);
}

[Theory]
[ActiveIssue("https://github.com/dotnet/winforms/issues/13117")]
[Theory(Skip = "Localization tests, see: https://github.com/dotnet/winforms/issues/13117")]
[InlineData("fr-FR", Keys.None, "(aucun)")]
[InlineData("de-DE", Keys.End, "Ende")]
public void ConvertToString_ShouldConvertKeys_Localization(string cultureName, Keys key, string expectedLocalizedKeyName)
Expand Down
5 changes: 3 additions & 2 deletions src/test/unit/System.Windows.Forms/System/Windows/Forms/ToolStripMenuItemTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.ComponentModel;
Expand Down Expand Up @@ -143,7 +143,8 @@ public void ToolStripMenuItem_SetShortcutKeys_ThrowsInvalidEnumArgumentException
Assert.Throws<InvalidEnumArgumentException>(() => item.ShortcutKeys = keys);
}

[WinFormsTheory]
[ActiveIssue("https://github.com/dotnet/winforms/issues/13117")]
[WinFormsTheory(Skip = "Localization tests, see: https://github.com/dotnet/winforms/issues/13117")]
[MemberData(nameof(CultureInfo_Shortcut_TestData))]
public void ToolStripMenuItem_SetShortcutKeys_ReturnExpectedShortcutText(CultureInfo threadCulture, CultureInfo threadUICulture, string expectedShortcutText)
{
Expand Down