Skip to content

Conversation

NullVoxPopuli
Copy link
Contributor

No description provided.

@@ -97,7 +97,7 @@
"npm-package-json-lint": "^7.0.0",
"npm-run-all": "^4.1.5",
"prettier": "^3.0.3",
"release-plan": "^0.11.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah, this was quite old!

- run: pnpm install --frozen-lockfile
- run: pnpm release-plan publish --provenance
- name: Publish to NPM
run: NPM_CONFIG_PROVENANCE=true pnpm release-plan publish
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we get provenance now

Copy link
Member

@bmish bmish Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provenance was working successfully as of 12.7.3.

Why the need to use NPM_CONFIG_PROVENANCE=true instead of just --provenance now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a question for here, but for the release-plan-setup -- none of these choices are "mine" but just "boilerplate so I don't have to maintain anything"

runs-on: ubuntu-latest
outputs:
command: ${{ steps.check-release.outputs.command }}

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to downgrade actions/checkout and actions/setup-node?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a question for here, but for the release-plan-setup -- none of these choices are "mine" but just "boilerplate so I don't have to maintain anything"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real answer: v5 came out like.. this week, ya?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants