-
-
Notifications
You must be signed in to change notification settings - Fork 210
pnpm dlx create-release-plan-setup@latest --update #2334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
# For every push to the master branch, this checks if the release-plan was | ||
# updated and if it was it will publish stable npm packages based on the | ||
# release plan | ||
# For every push to the primary branch with .release-plan.json modified, | ||
# runs release-plan. | ||
|
||
name: Publish Stable | ||
|
||
|
@@ -10,49 +9,35 @@ on: | |
branches: | ||
- main | ||
- master | ||
paths: | ||
- '.release-plan.json' | ||
|
||
concurrency: | ||
group: publish-${{ github.head_ref || github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
check-plan: | ||
name: "Check Release Plan" | ||
runs-on: ubuntu-latest | ||
outputs: | ||
command: ${{ steps.check-release.outputs.command }} | ||
|
||
steps: | ||
- uses: actions/checkout@v5 | ||
with: | ||
fetch-depth: 0 | ||
ref: 'master' | ||
# This will only cause the `check-plan` job to have a result of `success` | ||
# when the .release-plan.json file was changed on the last commit. This | ||
# plus the fact that this action only runs on main will be enough of a guard | ||
- id: check-release | ||
run: if git diff --name-only HEAD HEAD~1 | grep -w -q ".release-plan.json"; then echo "command=release"; fi >> $GITHUB_OUTPUT | ||
|
||
publish: | ||
name: "NPM Publish" | ||
runs-on: ubuntu-latest | ||
needs: check-plan | ||
if: needs.check-plan.outputs.command == 'release' | ||
permissions: | ||
contents: write | ||
pull-requests: write | ||
id-token: write | ||
attestations: write | ||
|
||
steps: | ||
- uses: actions/checkout@v5 | ||
- uses: actions/checkout@v4 | ||
- uses: pnpm/action-setup@v4 | ||
- uses: actions/setup-node@v5 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: 18 | ||
# This creates an .npmrc that reads the NODE_AUTH_TOKEN environment variable | ||
registry-url: 'https://registry.npmjs.org' | ||
cache: pnpm | ||
- run: pnpm install --frozen-lockfile | ||
- run: pnpm release-plan publish --provenance | ||
- name: Publish to NPM | ||
run: NPM_CONFIG_PROVENANCE=true pnpm release-plan publish | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we get provenance now There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. provenance was working successfully as of 12.7.3. Why the need to use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a question for here, but for the release-plan-setup -- none of these choices are "mine" but just "boilerplate so I don't have to maintain anything" |
||
env: | ||
GITHUB_AUTH: ${{ secrets.GITHUB_TOKEN }} | ||
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -97,7 +97,7 @@ | |
"npm-package-json-lint": "^7.0.0", | ||
"npm-run-all": "^4.1.5", | ||
"prettier": "^3.0.3", | ||
"release-plan": "^0.11.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. woah, this was quite old! |
||
"release-plan": "^0.17.0", | ||
"sort-package-json": "^2.6.0", | ||
"typescript": "^5.2.2", | ||
"typescript-eslint": "^8.7.0", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to downgrade
actions/checkout
andactions/setup-node
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a question for here, but for the release-plan-setup -- none of these choices are "mine" but just "boilerplate so I don't have to maintain anything"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
real answer: v5 came out like.. this week, ya?