Skip to content

Fix for errors when using OFFSCREENCANVAS_SUPPORT #25260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2025
Merged

Fix for errors when using OFFSCREENCANVAS_SUPPORT #25260

merged 3 commits into from
Sep 15, 2025

Conversation

wenhanchong
Copy link
Contributor

@wenhanchong wenhanchong commented Sep 11, 2025 •
edited
Loading

This PR addresses an error encountered while using OFFSCREENCANVAS_SUPPORT for pthreads.
Unable to find canvas in findCanvasEventTarget when canvas is specialHTMLTargets.

Uncaught TypeError: document.querySelector is not a function
    at findCanvasEventTarget
    at _wgpuInstanceCreateSurface

@sbc100 sbc100 requested a review from juj September 11, 2025 18:48
juj
juj reviewed Sep 11, 2025
View reviewed changes
juj
juj reviewed Sep 11, 2025
View reviewed changes
@wenhanchong wenhanchong requested a review from juj September 12, 2025 15:42
juj
juj reviewed Sep 12, 2025
View reviewed changes
@wenhanchong wenhanchong requested a review from juj September 15, 2025 02:06
@juj juj merged commit 9692a6d into emscripten-core:main Sep 15, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juj juj Awaiting requested review from juj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenhanchong @juj