Skip to content

Fix for errors when using OFFSCREENCANVAS_SUPPORT #25260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2025
+3 −1
Merged

Fix for errors when using OFFSCREENCANVAS_SUPPORT #25260

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1bc1ed
fix offscreencanvas support
Sep 11, 2025
2fc7c20
remove emscripten_set_canvas_size change, switch priority of specialH…
Sep 12, 2025
a51b33f
add findCanvasEventTarget deps
Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/libhtml5.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ var LibraryHTML5 = {
},

#if OFFSCREENCANVAS_SUPPORT
$findCanvasEventTarget__deps: ['$GL', '$maybeCStringToJsString'],
$findCanvasEventTarget__deps: ['$GL', '$maybeCStringToJsString', '$specialHTMLTargets'],
$findCanvasEventTarget: (target) => {
target = maybeCStringToJsString(target);

Expand All @@ -365,6 +365,8 @@ var LibraryHTML5 = {
// If not found, if one is querying by using DOM tag name selector 'canvas', grab the first
// OffscreenCanvas that we can find.
|| (target == 'canvas' && Object.keys(GL.offscreenCanvases)[0])
// If not found, check specialHTMLTargets
|| specialHTMLTargets[target]
// If that is not found either, query via the regular DOM selector.
#if PTHREADS
|| (typeof document != 'undefined' && document.querySelector(target));
Expand Down