feat(prefer-immutable-types): allow overriding options based on where the type is declared #804

RebeccaStevens · 2024-04-14T14:03:06Z

fix #800

RebeccaStevens · 2024-04-14T14:03:14Z

feat(prefer-immutable-types): allow overriding options based on where the type is declared #804 : 2 dependent PRs (#807 , #810 ) 👈
feat(functional-parameters): change options in recommended and lite configs #811
feat(functional-parameters): allow overriding options based on where the function type is declared #803
part: set up overridable options #812
test: migrate test to eslint-vitest-rule-tester #845
feat: eslint 9 migration #809 : 1 other dependent PR (#825 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on Graphite

RebeccaStevens · 2024-04-14T14:43:08Z

We probably want to bump the minimum ts version up to 4.7

graphite-app · 2024-08-05T07:11:04Z

Merge activity

Aug 5, 3:11 AM EDT: RebeccaStevens added this pull request to the Graphite merge queue.
Aug 5, 3:25 AM EDT: RebeccaStevens merged this pull request with the Graphite merge queue.

… the type is declared (#804) fix #800

# [7.0.0](v6.6.3...v7.0.0) (2024-08-05) ### Bug Fixes * checking of types from ts's lib are now more strict ([#862](#862)) ([39beb25](39beb25)) ### Features * eslint 9 migration ([#809](#809)) ([de4e3ea](de4e3ea)) * **functional-parameters:** allow overriding options based on where the function type is declared ([#803](#803)) ([21396d5](21396d5)), closes [#575](#575) * **functional-parameters:** change options in recommended and lite configs ([#811](#811)) ([b3cb8d9](b3cb8d9)) * **immutable-data:** allows for applying overrides to the options based on the root object's type ([#826](#826)) ([c04e425](c04e425)) * **no-classes:** add options ignoreIdentifierPattern and ignoreCodePattern ([#863](#863)) ([18aede1](18aede1)), closes [#851](#851) * **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](#839)) ([c2c589c](c2c589c)), closes [#838](#838) * **prefer-immutable-types:** allow overriding options based on where the type is declared ([#804](#804)) ([86fa76a](86fa76a)), closes [#800](#800) * **prefer-immutable-types:** change the options in recommeneded and lite configs ([#810](#810)) ([defd713](defd713)) ### BREAKING CHANGES * **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` (#839)

github-actions · 2024-08-05T07:31:57Z

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

##### [v7.0.1](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#701-2024-08-07) ##### Bug Fixes - don't throw when typescript can't be resolved ([afb05bd](eslint-functional/eslint-plugin-functional@afb05bd)) ##### [v7.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#700-2024-08-05) ##### Bug Fixes - checking of types from ts's lib are now more strict ([#862](eslint-functional/eslint-plugin-functional#862)) ([39beb25](eslint-functional/eslint-plugin-functional@39beb25)) ##### Features - eslint 9 migration ([#809](eslint-functional/eslint-plugin-functional#809)) ([de4e3ea](eslint-functional/eslint-plugin-functional@de4e3ea)) - **functional-parameters:** allow overriding options based on where the function type is declared ([#803](eslint-functional/eslint-plugin-functional#803)) ([21396d5](eslint-functional/eslint-plugin-functional@21396d5)), closes [#575](eslint-functional/eslint-plugin-functional#575) - **functional-parameters:** change options in recommended and lite configs ([#811](eslint-functional/eslint-plugin-functional#811)) ([b3cb8d9](eslint-functional/eslint-plugin-functional@b3cb8d9)) - **immutable-data:** allows for applying overrides to the options based on the root object's type ([#826](eslint-functional/eslint-plugin-functional#826)) ([c04e425](eslint-functional/eslint-plugin-functional@c04e425)) - **no-classes:** add options ignoreIdentifierPattern and ignoreCodePattern ([#863](eslint-functional/eslint-plugin-functional#863)) ([18aede1](eslint-functional/eslint-plugin-functional@18aede1)), closes [#851](eslint-functional/eslint-plugin-functional#851) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) ([c2c589c](eslint-functional/eslint-plugin-functional@c2c589c)), closes [#838](eslint-functional/eslint-plugin-functional#838) - **prefer-immutable-types:** allow overriding options based on where the type is declared ([#804](eslint-functional/eslint-plugin-functional#804)) ([86fa76a](eslint-functional/eslint-plugin-functional@86fa76a)), closes [#800](eslint-functional/eslint-plugin-functional#800) - **prefer-immutable-types:** change the options in recommeneded and lite configs ([#810](eslint-functional/eslint-plugin-functional#810)) ([defd713](eslint-functional/eslint-plugin-functional@defd713)) ##### BREAKING CHANGES - The minimum supported Node version is now 18.18.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported TypeScript version is now 4.7.4 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported Eslint version is now 9.0.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) #### [6.6.3](eslint-functional/eslint-plugin-functional@v6.6.2...v6.6.3) (2024-07-11) ##### Bug Fixes - **immutable-data:** ignoreAccessorPattern can now handle NonNullExpressions and ChainExpressions ([#849](eslint-functional/eslint-plugin-functional#849)) ([f6ff69b](eslint-functional/eslint-plugin-functional@f6ff69b)), closes [#840](eslint-functional/eslint-plugin-functional#840) #### [6.6.2](eslint-functional/eslint-plugin-functional@v6.6.1...v6.6.2) (2024-07-11) ##### Bug Fixes - **no-conditional-statements:** allow continue and break statements with labels to be considered "returning" ([#846](eslint-functional/eslint-plugin-functional#846)) ([969b77b](eslint-functional/eslint-plugin-functional@969b77b)) - **no-expression-statements:** arrow functions cannot be self returning ([#847](eslint-functional/eslint-plugin-functional#847)) ([7217fa4](eslint-functional/eslint-plugin-functional@7217fa4)) - **no-promise-reject:** new Promises and throw statements are now also checked ([#848](eslint-functional/eslint-plugin-functional#848)) ([fbe27ad](eslint-functional/eslint-plugin-functional@fbe27ad)) #### [6.6.1](eslint-functional/eslint-plugin-functional@v6.6.0...v6.6.1) (2024-07-06)

RebeccaStevens mentioned this pull request Apr 14, 2024

feat(functional-parameters): allow overriding options based on where the function type is declared #803

Merged

RebeccaStevens marked this pull request as ready for review April 14, 2024 14:04

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 0a6bd90 to f31eb30 Compare April 14, 2024 14:13

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0130f0f to 63f36f3 Compare April 14, 2024 14:13

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from f31eb30 to c24ea84 Compare April 14, 2024 14:16

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 63f36f3 to d246ac3 Compare April 14, 2024 14:16

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from c24ea84 to bf25112 Compare April 14, 2024 14:27

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from d246ac3 to 7c09967 Compare April 14, 2024 14:27

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from bf25112 to 8bfc725 Compare April 15, 2024 06:54

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 7c09967 to d33e2c7 Compare April 15, 2024 06:54

RebeccaStevens mentioned this pull request Apr 15, 2024

feat(perfer-tacit): allow specifying which type need binds #807

Closed

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 8bfc725 to 20f7137 Compare April 15, 2024 08:33

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from d33e2c7 to 78839d6 Compare April 15, 2024 08:33

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 20f7137 to 61e4e86 Compare April 16, 2024 09:34

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 78839d6 to a1a2526 Compare April 16, 2024 09:34

RebeccaStevens mentioned this pull request Apr 16, 2024

feat: eslint 9 migration #809

Merged

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 61e4e86 to 90bb5eb Compare April 17, 2024 12:16

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from a1a2526 to f62f410 Compare April 17, 2024 12:16

This was referenced Apr 18, 2024

feat(prefer-immutable-types): change the options in recommeneded and lite configs #810

Merged

feat(functional-parameters): change options in recommended and lite configs #811

Merged

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 90bb5eb to 71364aa Compare April 22, 2024 12:33

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f62f410 to 414f358 Compare April 22, 2024 12:33

RebeccaStevens mentioned this pull request Apr 22, 2024

part: set up overridable options #812

Merged

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 71364aa to 4a927d8 Compare April 22, 2024 15:25

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 414f358 to 389d79d Compare April 22, 2024 15:25

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 4a927d8 to 8387695 Compare April 22, 2024 16:03

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 389d79d to dd561f5 Compare April 22, 2024 16:03

RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 8387695 to 854b721 Compare April 30, 2024 06:05

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 5eeabe0 to 9544b7f Compare August 3, 2024 09:19

RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from ca28a4a to fe6a517 Compare August 5, 2024 06:56

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 9544b7f to 528cc24 Compare August 5, 2024 06:56

RebeccaStevens mentioned this pull request Aug 5, 2024

chore: add graphite labels #864

Merged

RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from fe6a517 to 5477b51 Compare August 5, 2024 07:06

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 528cc24 to e5f6ce4 Compare August 5, 2024 07:06

RebeccaStevens added the Status: Merge Queue Merge the stack with the merge queue label Aug 5, 2024 — with Graphite App

feat(prefer-immutable-types): allow overriding options based on where…

86fa76a

… the type is declared (#804) fix #800

RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 5477b51 to b3cb8d9 Compare August 5, 2024 07:14

RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from e5f6ce4 to 86fa76a Compare August 5, 2024 07:14

RebeccaStevens changed the base branch from 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs to main August 5, 2024 07:24

graphite-app bot merged commit 86fa76a into main Aug 5, 2024
16 checks passed

graphite-app bot deleted the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch August 5, 2024 07:25

github-actions bot added the Status: Released It's now live. label Aug 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(prefer-immutable-types): allow overriding options based on where the type is declared #804

feat(prefer-immutable-types): allow overriding options based on where the type is declared #804

Uh oh!

RebeccaStevens commented Apr 14, 2024 •

edited

Loading

Uh oh!

RebeccaStevens commented Apr 14, 2024 •

edited

Loading

Uh oh!

RebeccaStevens commented Apr 14, 2024

Uh oh!

graphite-app bot commented Aug 5, 2024 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Aug 5, 2024

Uh oh!

Uh oh!

Uh oh!

feat(prefer-immutable-types): allow overriding options based on where the type is declared #804

feat(prefer-immutable-types): allow overriding options based on where the type is declared #804

Uh oh!

Conversation

RebeccaStevens commented Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RebeccaStevens commented Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RebeccaStevens commented Apr 14, 2024

Uh oh!

graphite-app bot commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

github-actions bot commented Aug 5, 2024

Uh oh!

Uh oh!

RebeccaStevens commented Apr 14, 2024 •

edited

Loading

RebeccaStevens commented Apr 14, 2024 •

edited

Loading

graphite-app bot commented Aug 5, 2024 •

edited

Loading