feat(no-throw-statements)!: replace option `allowInAsyncFunctions` with `allowToRejectPromises` #839

RebeccaStevens · 2024-06-24T11:52:15Z

graphite-app · 2024-06-24T11:52:19Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “Status: Merge Queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “Status: Hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

RebeccaStevens · 2024-06-24T11:52:26Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on Graphite

graphite-app · 2024-08-05T07:11:06Z

Merge activity

Aug 5, 3:11 AM EDT: RebeccaStevens added this pull request to the Graphite merge queue.
Aug 5, 3:28 AM EDT: RebeccaStevens merged this pull request with the Graphite merge queue.

…th `allowToRejectPromises` (#839) fix #838

# [7.0.0](v6.6.3...v7.0.0) (2024-08-05) ### Bug Fixes * checking of types from ts's lib are now more strict ([#862](#862)) ([39beb25](39beb25)) ### Features * eslint 9 migration ([#809](#809)) ([de4e3ea](de4e3ea)) * **functional-parameters:** allow overriding options based on where the function type is declared ([#803](#803)) ([21396d5](21396d5)), closes [#575](#575) * **functional-parameters:** change options in recommended and lite configs ([#811](#811)) ([b3cb8d9](b3cb8d9)) * **immutable-data:** allows for applying overrides to the options based on the root object's type ([#826](#826)) ([c04e425](c04e425)) * **no-classes:** add options ignoreIdentifierPattern and ignoreCodePattern ([#863](#863)) ([18aede1](18aede1)), closes [#851](#851) * **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](#839)) ([c2c589c](c2c589c)), closes [#838](#838) * **prefer-immutable-types:** allow overriding options based on where the type is declared ([#804](#804)) ([86fa76a](86fa76a)), closes [#800](#800) * **prefer-immutable-types:** change the options in recommeneded and lite configs ([#810](#810)) ([defd713](defd713)) ### BREAKING CHANGES * **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` (#839)

github-actions · 2024-08-05T07:31:48Z

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

##### [v7.0.1](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#701-2024-08-07) ##### Bug Fixes - don't throw when typescript can't be resolved ([afb05bd](eslint-functional/eslint-plugin-functional@afb05bd)) ##### [v7.0.0](https://github.com/eslint-functional/eslint-plugin-functional/blob/HEAD/CHANGELOG.md#700-2024-08-05) ##### Bug Fixes - checking of types from ts's lib are now more strict ([#862](eslint-functional/eslint-plugin-functional#862)) ([39beb25](eslint-functional/eslint-plugin-functional@39beb25)) ##### Features - eslint 9 migration ([#809](eslint-functional/eslint-plugin-functional#809)) ([de4e3ea](eslint-functional/eslint-plugin-functional@de4e3ea)) - **functional-parameters:** allow overriding options based on where the function type is declared ([#803](eslint-functional/eslint-plugin-functional#803)) ([21396d5](eslint-functional/eslint-plugin-functional@21396d5)), closes [#575](eslint-functional/eslint-plugin-functional#575) - **functional-parameters:** change options in recommended and lite configs ([#811](eslint-functional/eslint-plugin-functional#811)) ([b3cb8d9](eslint-functional/eslint-plugin-functional@b3cb8d9)) - **immutable-data:** allows for applying overrides to the options based on the root object's type ([#826](eslint-functional/eslint-plugin-functional#826)) ([c04e425](eslint-functional/eslint-plugin-functional@c04e425)) - **no-classes:** add options ignoreIdentifierPattern and ignoreCodePattern ([#863](eslint-functional/eslint-plugin-functional#863)) ([18aede1](eslint-functional/eslint-plugin-functional@18aede1)), closes [#851](eslint-functional/eslint-plugin-functional#851) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) ([c2c589c](eslint-functional/eslint-plugin-functional@c2c589c)), closes [#838](eslint-functional/eslint-plugin-functional#838) - **prefer-immutable-types:** allow overriding options based on where the type is declared ([#804](eslint-functional/eslint-plugin-functional#804)) ([86fa76a](eslint-functional/eslint-plugin-functional@86fa76a)), closes [#800](eslint-functional/eslint-plugin-functional#800) - **prefer-immutable-types:** change the options in recommeneded and lite configs ([#810](eslint-functional/eslint-plugin-functional#810)) ([defd713](eslint-functional/eslint-plugin-functional@defd713)) ##### BREAKING CHANGES - The minimum supported Node version is now 18.18.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported TypeScript version is now 4.7.4 ([#809](eslint-functional/eslint-plugin-functional#809)) - The minimum supported Eslint version is now 9.0.0 ([#809](eslint-functional/eslint-plugin-functional#809)) - **no-throw-statements:** replace option `allowInAsyncFunctions` with `allowToRejectPromises` ([#839](eslint-functional/eslint-plugin-functional#839)) #### [6.6.3](eslint-functional/eslint-plugin-functional@v6.6.2...v6.6.3) (2024-07-11) ##### Bug Fixes - **immutable-data:** ignoreAccessorPattern can now handle NonNullExpressions and ChainExpressions ([#849](eslint-functional/eslint-plugin-functional#849)) ([f6ff69b](eslint-functional/eslint-plugin-functional@f6ff69b)), closes [#840](eslint-functional/eslint-plugin-functional#840) #### [6.6.2](eslint-functional/eslint-plugin-functional@v6.6.1...v6.6.2) (2024-07-11) ##### Bug Fixes - **no-conditional-statements:** allow continue and break statements with labels to be considered "returning" ([#846](eslint-functional/eslint-plugin-functional#846)) ([969b77b](eslint-functional/eslint-plugin-functional@969b77b)) - **no-expression-statements:** arrow functions cannot be self returning ([#847](eslint-functional/eslint-plugin-functional#847)) ([7217fa4](eslint-functional/eslint-plugin-functional@7217fa4)) - **no-promise-reject:** new Promises and throw statements are now also checked ([#848](eslint-functional/eslint-plugin-functional#848)) ([fbe27ad](eslint-functional/eslint-plugin-functional@fbe27ad)) #### [6.6.1](eslint-functional/eslint-plugin-functional@v6.6.0...v6.6.1) (2024-07-06)

RebeccaStevens mentioned this pull request Jun 24, 2024

feat(prefer-immutable-types): change the options in recommeneded and lite configs #810

Merged

RebeccaStevens mentioned this pull request Jun 24, 2024

feat(immutable-data): allows for applying overrides to the options based on the root object's type #826

Merged

RebeccaStevens marked this pull request as ready for review June 24, 2024 11:52

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from 87bfb3b to 322dfc9 Compare June 30, 2024 07:11

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from fd3b0d0 to c2eb222 Compare June 30, 2024 07:11

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from 322dfc9 to d399066 Compare June 30, 2024 08:25

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch 2 times, most recently from 031ef8e to 9414dcf Compare July 5, 2024 09:14

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch 2 times, most recently from 23b1c44 to 7a86c94 Compare July 6, 2024 02:25

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from 9414dcf to 444d6af Compare July 6, 2024 02:25

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from 7a86c94 to dc9d212 Compare July 6, 2024 03:44

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from 444d6af to 15c80e1 Compare July 6, 2024 03:44

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from dc9d212 to 954856e Compare July 10, 2024 14:41

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from 15c80e1 to 9a104aa Compare July 10, 2024 14:41

RebeccaStevens mentioned this pull request Jul 10, 2024

test: migrate test to eslint-vitest-rule-tester #845

Merged

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from 954856e to c0ca0b7 Compare July 11, 2024 08:05

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from 9a104aa to 60ad3c0 Compare July 11, 2024 08:05

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from c0ca0b7 to 38486c0 Compare July 11, 2024 08:29

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch 2 times, most recently from a9d36e9 to e1a8b59 Compare July 11, 2024 08:40

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from 38486c0 to 97db310 Compare July 11, 2024 10:41

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from e1a8b59 to 6ade5e9 Compare July 11, 2024 10:41

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from 97db310 to 5f4589c Compare July 26, 2024 04:23

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from 6ade5e9 to d880185 Compare July 26, 2024 04:23

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from 5f4589c to 9042739 Compare July 29, 2024 10:45

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from d880185 to 7b3b400 Compare July 29, 2024 10:45

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from 9042739 to 89c0ed7 Compare July 29, 2024 12:00

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from ed6940a to 08b45f9 Compare August 3, 2024 09:20

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from 64c773e to 50c9f0d Compare August 5, 2024 06:56

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from 08b45f9 to 74cef30 Compare August 5, 2024 06:57

RebeccaStevens mentioned this pull request Aug 5, 2024

chore: add graphite labels #864

Merged

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from 50c9f0d to d5bfbf3 Compare August 5, 2024 07:07

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from 74cef30 to 1b8b7e7 Compare August 5, 2024 07:07

RebeccaStevens added the Status: Merge Queue Merge the stack with the merge queue label Aug 5, 2024 — with Graphite App

feat(no-throw-statements)!: replace option allowInAsyncFunctions wi…

c2c589c

…th `allowToRejectPromises` (#839) fix #838

RebeccaStevens force-pushed the 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type branch from d5bfbf3 to c04e425 Compare August 5, 2024 07:15

RebeccaStevens force-pushed the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch from 1b8b7e7 to c2c589c Compare August 5, 2024 07:16

RebeccaStevens changed the base branch from 05-06-feat_immutable-data_allows_for_applying_overrides_to_the_options_based_on_the_root_object_s_type to main August 5, 2024 07:26

graphite-app bot merged commit c2c589c into main Aug 5, 2024
16 checks passed

graphite-app bot deleted the 06-24-feat_no-throw-statements_replace_option_allowinasyncfunctions_with_allowtorejectpromises_ branch August 5, 2024 07:28

github-actions bot added the Status: Released It's now live. label Aug 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(no-throw-statements)!: replace option `allowInAsyncFunctions` with `allowToRejectPromises` #839

feat(no-throw-statements)!: replace option `allowInAsyncFunctions` with `allowToRejectPromises` #839

Uh oh!

RebeccaStevens commented Jun 24, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 24, 2024

Uh oh!

RebeccaStevens commented Jun 24, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Aug 5, 2024 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Aug 5, 2024

Uh oh!

Uh oh!

Uh oh!

feat(no-throw-statements)!: replace option allowInAsyncFunctions with allowToRejectPromises #839

feat(no-throw-statements)!: replace option allowInAsyncFunctions with allowToRejectPromises #839

Uh oh!

Conversation

RebeccaStevens commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jun 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

RebeccaStevens commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

github-actions bot commented Aug 5, 2024

Uh oh!

Uh oh!

feat(no-throw-statements)!: replace option `allowInAsyncFunctions` with `allowToRejectPromises` #839

feat(no-throw-statements)!: replace option `allowInAsyncFunctions` with `allowToRejectPromises` #839

RebeccaStevens commented Jun 24, 2024 •

edited

Loading

RebeccaStevens commented Jun 24, 2024 •

edited

Loading

graphite-app bot commented Aug 5, 2024 •

edited

Loading