Add AGGREGATE_AND_PROOF_V2 to support EIP-7549 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
previously approved these changes
Sep 20, 2024
There was a problem hiding this comment.
This looks good to me I think, @usmansaleem @jframe cc what do you think
1 task
jframe
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Changes look fine to me too. But will leave it to @usmansaleem to give the final approval since he is working the changes in web3signer
james-prysm
approved these changes
Sep 23, 2024
3 tasks
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #15, this PR adds
AGGREGATE_AND_PROOF_V2to support signingAggregateAndProofacross different forks. This is required as it signs overAttestationwhich is modified in electra.