Adding Fulu changes #21
Conversation
-- Update version to 1.3.0
1.2.0 doesn't seem to exist, or is there a reason for skipping it? |
| @@ -177,6 +179,19 @@ components: | |||
| required: | |||
| - version | |||
| - data | |||
| AggregateAndProofRequestFulu: | |||
There was a problem hiding this comment.
what changed here for Fulu?
There was a problem hiding this comment.
this is needed for version I think but we can just reference AggregateAndProofElectra on line 193
| @@ -731,6 +770,19 @@ components: | |||
| required: | |||
| - version | |||
| - block_header | |||
| BlockRequestFulu: | |||
There was a problem hiding this comment.
Fulu block is just electra block 🤔
There was a problem hiding this comment.
version field needs update though
signing/schemas.yaml
Outdated
| @@ -461,6 +476,17 @@ components: | |||
| type: "string" | |||
| committee_bits: | |||
| type: "string" | |||
| AttestationFulu: | |||
There was a problem hiding this comment.
i don't think there's a attestation fulu
| @@ -177,6 +179,19 @@ components: | |||
| required: | |||
| - version | |||
| - data | |||
| AggregateAndProofRequestFulu: | |||
There was a problem hiding this comment.
this is needed for version I think but we can just reference AggregateAndProofElectra on line 193
signing/schemas.yaml
Outdated
| @@ -556,6 +582,17 @@ components: | |||
| selection_proof: | |||
| type: string | |||
| description: Bytes96 hexadecimal | |||
| AggregateAndProofFulu: | |||
There was a problem hiding this comment.
can be removed as it's same as AggregateAndProofElectra
| @@ -731,6 +770,19 @@ components: | |||
| required: | |||
| - version | |||
| - block_header | |||
| BlockRequestFulu: | |||
There was a problem hiding this comment.
version field needs update though
I think we missed cutting a release at #17. It should've been tagged as 1.2.0 |
signing/schemas.yaml
Outdated
| @@ -164,13 +165,14 @@ components: | |||
| required: | |||
| - version | |||
| - data | |||
| AggregateAndProofRequestElectra: | |||
| AggregateAndProofRequestElectraOrFulu: | |||
There was a problem hiding this comment.
doesn't this break the mapping? ie. now FULU version can be valid for ELECTRA
would probably just copy-paste and create a AggregateAndProofRequestFulu with only FULU as version but it can reference AggregateAndProofElectra since it's unchanged
same for BlockRequestFulu as there are no changes there
|
@nflaig @james-prysm I've pushed v1.2.0 tag as well (which we missed when we made ELECTRA changes). I've updated the index.html with it as well. |
-- Update version to 1.3.0