Skip to content

feat(billing): Add downsampled_event_retention to project configs #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2025
Merged

feat(billing): Add downsampled_event_retention to project configs #5013

merged 3 commits into from
Aug 8, 2025

Conversation

brendanhsentry
Copy link
Member

@brendanhsentry brendanhsentry commented Jul 31, 2025 •
edited by onkar
Loading

Adding downsampled_event_retention to project configs as part of the retention changes project

See getsentry/sentry#96818 and https://github.com/getsentry/getsentry/pull/18058 for how it'll be set.

This PR is the first change needed to resolve https://linear.app/getsentry/issue/EAP-160/modify-the-org-setting-to-reflect-the-retention-change-based-on-the.

@brendanhsentry brendanhsentry marked this pull request as ready for review August 1, 2025 21:14
@brendanhsentry brendanhsentry requested a review from a team as a code owner August 1, 2025 21:14
@brendanhsentry brendanhsentry mentioned this pull request Aug 1, 2025
Merged
Dav1dde
Dav1dde reviewed Aug 4, 2025
View reviewed changes
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to actually make use of the new retention, or is this planned to be in a follow-up/something you want us (ingest) to work on?

Also please add a changelog message to CHANGELOG.md and py/CHANGELOG.md.

@brendanhsentry brendanhsentry force-pushed the brendan/downsampled-event-retention branch from 027b6b6 to 1d9db0f Compare August 6, 2025 15:10
@brendanhsentry brendanhsentry changed the title feat(eap): add downsampled_event_retention to project configs feat(billing): Add downsampled_event_retention to project configs Aug 6, 2025
@brendanhsentry
Copy link
Member Author

Do you want to actually make use of the new retention, or is this planned to be in a follow-up/something you want us (ingest) to work on?

@phacops will make use of this. I'm just helping him set the values for various billing plans @Dav1dde

@phacops
Copy link
Contributor

phacops commented Aug 6, 2025

Do you want to actually make use of the new retention, or is this planned to be in a follow-up/something you want us (ingest) to work on?

@phacops will make use of this. I'm just helping him set the values for various billing plans @Dav1dde

Indeed I will. We could upgrade sentry-protos now and make sure every TraceItem received the downsampled event retention though.

@brendanhsentry what value will downsampled event retention have right now?

@brendanhsentry
Copy link
Member Author

Do you want to actually make use of the new retention, or is this planned to be in a follow-up/something you want us (ingest) to work on?

@phacops will make use of this. I'm just helping him set the values for various billing plans @Dav1dde

Indeed I will. We could upgrade sentry-protos now and make sure every TraceItem received the downsampled event retention though.

@brendanhsentry what value will downsampled event retention have right now?

I believe it should be None until getsentry/sentry#96818 and https://github.com/getsentry/getsentry/pull/18058 are merged. I've temporarily defaulted them to 0 in those PRs as I'm not sure which phase of the rollout we're in. @phacops

@phacops
Copy link
Contributor

phacops commented Aug 7, 2025

I've temporarily defaulted them to 0 in those PRs as I'm not sure which phase of the rollout we're in.

This is OK as a default, we give it the normal retention in the consumer in that case.

@brendanhsentry brendanhsentry added this pull request to the merge queue Aug 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2025
@brendanhsentry brendanhsentry added this pull request to the merge queue Aug 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2025
@phacops phacops enabled auto-merge August 8, 2025 14:17
@phacops phacops added this pull request to the merge queue Aug 8, 2025
Merged via the queue into master with commit fd29acd Aug 8, 2025
29 checks passed
@phacops phacops deleted the brendan/downsampled-event-retention branch August 8, 2025 14:47
@linear Linear
Copy link

linear bot commented Aug 8, 2025

EAP-160 Modify the org setting to reflect the retention change based on the billing plan

@brendanhsentry brendanhsentry mentioned this pull request Aug 11, 2025
Merged
brendanhsentry added a commit to getsentry/sentry that referenced this pull request Aug 11, 2025
@brendanhsentry @joshuarli
ref: bump sentry-relay to 0.9.11 (#97604)
980b2ce 
adds `downsampled_event_retention` see
getsentry/relay#5013

---------

Co-authored-by: Joshua Li <[email protected]>
andrewshie-sentry pushed a commit to getsentry/sentry that referenced this pull request Aug 12, 2025
@brendanhsentry @joshuarli @andrewshie-sentry
ref: bump sentry-relay to 0.9.11 (#97604)
bb0403d 
adds `downsampled_event_retention` see
getsentry/relay#5013

---------

Co-authored-by: Joshua Li <[email protected]>
brendanhsentry added a commit to getsentry/sentry that referenced this pull request Aug 14, 2025
@brendanhsentry
feat(eap): add downsampled event retention to config (#96818)
fc69657 
depends on getsentry/relay#5013

This PR is the second change needed to resolve
https://linear.app/getsentry/issue/EAP-160/modify-the-org-setting-to-reflect-the-retention-change-based-on-the.
priscilawebdev pushed a commit to getsentry/sentry that referenced this pull request Aug 25, 2025
@brendanhsentry @joshuarli @priscilawebdev
ref: bump sentry-relay to 0.9.11 (#97604)
157a2ea 
adds `downsampled_event_retention` see
getsentry/relay#5013

---------

Co-authored-by: Joshua Li <[email protected]>
priscilawebdev pushed a commit to getsentry/sentry that referenced this pull request Aug 25, 2025
@brendanhsentry @priscilawebdev
feat(eap): add downsampled event retention to config (#96818)
d3f6c7e 
depends on getsentry/relay#5013

This PR is the second change needed to resolve
https://linear.app/getsentry/issue/EAP-160/modify-the-org-setting-to-reflect-the-retention-change-based-on-the.
andrewshie-sentry pushed a commit to getsentry/sentry that referenced this pull request Aug 26, 2025
@brendanhsentry @andrewshie-sentry
feat(eap): add downsampled event retention to config (#96818)
c2ef8b9 
depends on getsentry/relay#5013

This PR is the second change needed to resolve
https://linear.app/getsentry/issue/EAP-160/modify-the-org-setting-to-reflect-the-retention-change-based-on-the.
constantinius pushed a commit to getsentry/sentry that referenced this pull request Sep 1, 2025
@brendanhsentry @joshuarli @constantinius
ref: bump sentry-relay to 0.9.11 (#97604)
2a61251 
adds `downsampled_event_retention` see
getsentry/relay#5013

---------

Co-authored-by: Joshua Li <[email protected]>
constantinius pushed a commit to getsentry/sentry that referenced this pull request Sep 1, 2025
@brendanhsentry @constantinius
feat(eap): add downsampled event retention to config (#96818)
4aab185 
depends on getsentry/relay#5013

This PR is the second change needed to resolve
https://linear.app/getsentry/issue/EAP-160/modify-the-org-setting-to-reflect-the-retention-change-based-on-the.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dav1dde Dav1dde Dav1dde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendanhsentry @phacops @Dav1dde