feat(eap): add downsampled event retention to config #96818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96818 +/- ##
===========================================
+ Coverage 62.08% 80.16% +18.07%
===========================================
Files 8562 8513 -49
Lines 377263 378879 +1616
Branches 24577 24140 -437
===========================================
+ Hits 234234 303729 +69495
+ Misses 140572 74860 -65712
+ Partials 2457 290 -2167 |
github-merge-queue bot
pushed a commit
to getsentry/relay
that referenced
this pull request
Aug 7, 2025
) Adding `downsampled_event_retention` to project configs as part of the [retention changes project](https://www.notion.so/sentry/Retention-Changes-Summary-Jul-2025-2238b10e4b5d80e4b846d055178f334e?source=copy_link) See getsentry/sentry#96818 and getsentry/getsentry#18058 for how it'll be set.
github-merge-queue bot
pushed a commit
to getsentry/relay
that referenced
this pull request
Aug 7, 2025
) Adding `downsampled_event_retention` to project configs as part of the [retention changes project](https://www.notion.so/sentry/Retention-Changes-Summary-Jul-2025-2238b10e4b5d80e4b846d055178f334e?source=copy_link) See getsentry/sentry#96818 and getsentry/getsentry#18058 for how it'll be set.
github-merge-queue bot
pushed a commit
to getsentry/relay
that referenced
this pull request
Aug 8, 2025
) Adding `downsampled_event_retention` to project configs as part of the [retention changes project](https://www.notion.so/sentry/Retention-Changes-Summary-Jul-2025-2238b10e4b5d80e4b846d055178f334e?source=copy_link) See getsentry/sentry#96818 and getsentry/getsentry#18058 for how it'll be set. --------- Co-authored-by: Pierre Massat <[email protected]>
Dav1dde
reviewed
Aug 12, 2025
| Returns the retention for downsampled events in the given organization in days. | ||
| Returns ``None`` if downsampled events are to be stored indefinitely. | ||
| """ | ||
| return 0 |
There was a problem hiding this comment.
Comment says it returns None, this is actually 0.
There was a problem hiding this comment.
Ok I updated the docstring here fc37c5d
There was a problem hiding this comment.
Would there ever be a need to set retention to 0?
There was a problem hiding this comment.
No, we wouldn't. If you want a better default here, we can return get_event_retention()
| scrubData: true | ||
| scrubDefaults: true | ||
| sensitiveFields: [] | ||
| downsampledEventRetention: 0 |
There was a problem hiding this comment.
That seems bad, if we were to store 0?
There was a problem hiding this comment.
phacops
reviewed
Aug 13, 2025
| Returns the retention for downsampled events in the given organization in days. | ||
| Returns ``None`` if downsampled events are to be stored indefinitely. | ||
| """ | ||
| return 0 |
There was a problem hiding this comment.
I suppose this will read a value linked to the plan at some point?
There was a problem hiding this comment.
phacops
approved these changes
Aug 13, 2025
vbro
approved these changes
Aug 14, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
depends on getsentry/relay#5013 This PR is the second change needed to resolve https://linear.app/getsentry/issue/EAP-160/modify-the-org-setting-to-reflect-the-retention-change-based-on-the.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
depends on getsentry/relay#5013 This PR is the second change needed to resolve https://linear.app/getsentry/issue/EAP-160/modify-the-org-setting-to-reflect-the-retention-change-based-on-the.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on getsentry/relay#5013
This PR is the second change needed to resolve https://linear.app/getsentry/issue/EAP-160/modify-the-org-setting-to-reflect-the-retention-change-based-on-the.