Add NEL-related attributes #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes are reflecting the discussions from [this document](https://www.notion.so/sentry/Browser-Reports-Attribute-21e8b10e4b5d8045a7fdc936c814ed70) and follow-up to [this Relay PR](getsentry/relay#4874).
armenzg
commented
Jul 7, 2025
| @@ -5119,7 +5119,7 @@ export type SENTRY_OP_TYPE = string; | |||
| // Path: model/attributes/sentry/sentry__origin.json | |||
|
|
|||
| /** | |||
| * The origin of a span. `sentry.origin` | |||
| * The origin of the instrumentation (e.g. span, log, etc.). `sentry.origin` | |||
There was a problem hiding this comment.
Since it can now be used outside of the context of a span.
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
For this PR, you can experiment with the fields in here.
You can also refer to this w3c document.
model/attributes/nel/nel__phase.json
Outdated
| "type": "string", | ||
| "pii": { "key": "false" }, | ||
| "is_in_otel": false, | ||
| "example": "application" |
There was a problem hiding this comment.
e.g. dns, application , connection
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "key": "nel.referrer", | |||
| "type": "number", | ||
| "pii": { "key": "false" }, | ||
| "is_in_otel": false, | ||
| "example": 100 |
There was a problem hiding this comment.
For numeric examples, I assume I can put it without quotes.
There was a problem hiding this comment.
yup, this is valid. The tests should catch this.
|
Make sure you run |
AbhiPrasad
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are reflecting the discussions from this document and follow-up to this Relay PR.