Skip to content

Refresh generated attributes #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

Refresh generated attributes #70

merged 2 commits into from
Jul 7, 2025

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Jul 7, 2025

This will make reviewing #68 easier.

AbhiPrasad
AbhiPrasad reviewed Jul 7, 2025
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we had some merged PRs that didn't do this :(

Need to add CI steps for it (it's also annoying that the deprecated attributes don't get prettier formatted).

AbhiPrasad
AbhiPrasad approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge after we format.

@armenzg armenzg merged commit cfa0b54 into main Jul 7, 2025
5 checks passed
@armenzg armenzg deleted the generate/armenzg branch July 7, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@cleptric cleptric Awaiting requested review from cleptric

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armenzg @AbhiPrasad