Fix Authentication token expiration check #193
Merged
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184 and #190.
Throw an error if a token does not exist when building the Authorization header.
When using the GitHub OAuth app to authenticate, this is the
secure
object:expires_at
is null, so it always callsbuildHeaders
with an empty string (which doesn't make sense).Removed this erroneous code and throw an error if the header is being built without a token.