Skip to content

Fix Authentication token expiration check #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

Fix Authentication token expiration check #193

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6a38b7
throw an error if a token does not exist when building Authorization …
tonglil May 14, 2025
0521ff2
Update server/modules/authentication.ts
karpikpl Jun 5, 2025
72232a7
bump to 2.0.4
karpikpl Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions server/modules/authentication.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,14 @@ export async function authenticateAndGetGitHubHeaders(event: H3Event<EventHandle
// https://nuxt.com/docs/guide/recipes/sessions-and-authentication
const { secure } = await getUserSession(event);

// check if token is expired and get new one
if (secure && secure.expires_at < new Date(Date.now() - 30 * 1000)) {
// Token is expired or about to expire within 30 seconds
// we could refresh but unlikely dashboard is used for long periods
return buildHeaders('');
}

return buildHeaders(secure?.tokens.access_token || '');
return buildHeaders(secure?.tokens?.access_token || '');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

function buildHeaders(token: string): Headers {
if (!token) {
throw new Error('GitHub token is required');
}

return new Headers({
Accept: "application/vnd.github+json",
"X-GitHub-Api-Version": "2022-11-28",
Expand Down
Loading