-
Notifications
You must be signed in to change notification settings - Fork 18.4k
net/url: don't permit a colon after the port #75250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 679e749) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/700656. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Jes Cok: Patch Set 1: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-03T19:45:27Z","revision":"396f5a90e082e8f9a4ce5bdde986bb54b0b8cba6"} Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Jes Cok: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Jes Cok: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-04T00:35:45Z","revision":"396f5a90e082e8f9a4ce5bdde986bb54b0b8cba6"} Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Jes Cok: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Fixes golang#75223 Change-Id: Iaa12c7fc227ff33b8e97926d10967994a781720d
679e749
to
9a43608
Compare
This PR (HEAD: 9a43608) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/700656. Important tips:
|
Message from Jes Cok: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-04T12:09:59Z","revision":"3019bb9f831d4d207dcc7e6dc7bf811e3b24ab6c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Jes Cok: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):
To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Jes Cok: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-04T13:44:42Z","revision":"3019bb9f831d4d207dcc7e6dc7bf811e3b24ab6c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Jes Cok: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/700656. |
Fixes #75223