Skip to content

net/url: don't permit a colon after the port #75250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

net/url: don't permit a colon after the port #75250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/net/url/url.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,13 @@ func parseHost(host string) (string, error) {
return host1 + host2 + host3, nil
}
} else if i := strings.LastIndex(host, ":"); i != -1 {
if j := strings.LastIndex(host[:i], ":"); j != -1 { // multiple colons
if k := strings.LastIndex(host[:j], ":"); k == -1 { // only one other colon
if port := host[j:i]; validOptionalPort(port) { // see issue #75223
return "", fmt.Errorf("a colon after port %q is not allowed", port)
}
}
}
colonPort := host[i:]
if !validOptionalPort(colonPort) {
return "", fmt.Errorf("invalid port %q after host", colonPort)
Expand Down
14 changes: 14 additions & 0 deletions src/net/url/url_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,13 @@ var parseRequestURLTests = []struct {
// RFC 6874.
{"http://[fe80::1%en0]/", false},
{"http://[fe80::1%en0]:8080/", false},

{"http://x:x:", true}, // malformed IPv6 but still accepted
{"http://x::", false}, // a colon after empty port is not allowed
{"http://x:1:", false}, // a colon after the port is not allowed
{"http://x:12:", false}, // a colon after the port is not allowed
{"http://x:123:", false}, // a colon after the port is not allowed
{"http://127.0.0.1:8080:", false}, // a colon after the port is not allowed
}

func TestParseRequestURI(t *testing.T) {
Expand Down Expand Up @@ -1643,6 +1650,13 @@ func TestParseErrors(t *testing.T) {
{"cache_object:foo", true},
{"cache_object:foo/bar", true},
{"cache_object/:foo/bar", false},

{"http://x:x:", false}, // malformed IPv6 but still accepted
{"http://x::", true}, // a colon after empty port is not allowed
{"http://x:1:", true}, // a colon after the port is not allowed
{"http://x:12:", true}, // a colon after the port is not allowed
{"http://x:123:", true}, // a colon after the port is not allowed
{"http://127.0.0.1:8080:", true}, // a colon after the port is not allowed
}
for _, tt := range tests {
u, err := Parse(tt.in)
Expand Down