Skip to content

feat(client, formatter): forge fmt #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2022
Merged

feat(client, formatter): forge fmt #359

merged 4 commits into from
Sep 9, 2022

Conversation

shekhirin
Copy link
Contributor

@shekhirin shekhirin commented Aug 19, 2022 •
edited
Loading

Feel free to test it on your codebase!

  1. Package the extension with npm run package
  2. Import the extension in VS Code with Install from VSIX... from solidity-0.0.138.vsix in the vscode-solidity project root
    image
  3. Choose forge as a formatter in settings
    image

@fubhy fubhy mentioned this pull request Aug 20, 2022
Merged
joejordan
joejordan reviewed Sep 5, 2022
View reviewed changes
@shekhirin shekhirin changed the title WIP: feat(client, formatter): forge fmt feat(client, formatter): forge fmt Sep 5, 2022
@shekhirin shekhirin marked this pull request as ready for review September 5, 2022 21:03
joejordan
joejordan reviewed Sep 5, 2022
View reviewed changes
benharbit
benharbit reviewed Sep 6, 2022
View reviewed changes
Copy link

@benharbit benharbit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested eed78ac branch and it worked.

@juanfranblanco
Copy link
Owner

Thank you!!

@juanfranblanco juanfranblanco merged commit dda4a1e into juanfranblanco:master Sep 9, 2022
@vseehausen
Copy link

Thank you, this is great.

Small thing: The formatter does not recognize formatting options written in the foundry.toml file.

Is there a way to apply those configurations?

@juanfranblanco
Copy link
Owner

@shekhirin ^^

@shekhirin
Copy link
Contributor Author

yep, it's currently not respected, can confirm! Opened a PR to set current working directory during formatting: #363

@shekhirin shekhirin mentioned this pull request Sep 16, 2022
Merged
@just2102
Copy link

Does not work on Windows.
image
image

@just2102 just2102 mentioned this pull request Jul 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@joejordan joejordan joejordan left review comments

@benharbit benharbit benharbit left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shekhirin @juanfranblanco @vseehausen @just2102 @joejordan @benharbit