Do not throw if the secrets manager is disabled #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to use the secrets manager, the plugin need to sign before being activated. But we could still expect the extension to be activated without it.
The
sign
function throw if the secrets manager is disabled, which prevents the plugins to get activated without the secrets manager activated.This PR only warns if the manager is disabled, leaving the plugin concerned to manage its own secrets.
cc. @afshin who was the first to implement the
sign
function.