Skip to content

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented May 20, 2025

To be able to use the secrets manager, the plugin need to sign before being activated. But we could still expect the extension to be activated without it.
The sign function throw if the secrets manager is disabled, which prevents the plugins to get activated without the secrets manager activated.

This PR only warns if the manager is disabled, leaving the plugin concerned to manage its own secrets.

cc. @afshin who was the first to implement the sign function.

@brichet brichet added the bug Something isn't working label May 20, 2025
@brichet brichet closed this May 20, 2025
@brichet brichet force-pushed the do_not_raise_if_manager_disabled branch from 20bac54 to b2b5541 Compare May 20, 2025 13:54
@brichet brichet reopened this May 20, 2025
@brichet
Copy link
Collaborator Author

brichet commented May 20, 2025

Don't know how I closed this one.

@afshin
Copy link
Contributor

afshin commented May 21, 2025

This change makes sense. I would simplify the lock function to have the same signature as before but if message is an empty string, to simply not throw.

(I don't feel strongly about this, though, and either way your change is reasonable.)

@brichet
Copy link
Collaborator Author

brichet commented May 21, 2025

Thanks for the suggestion.
I updated the PR, but the signature changed anyway, the message argument is now optional. The error is thrown only if message is provided.

@brichet brichet merged commit e9f31e6 into jupyterlab-contrib:main May 21, 2025
6 checks passed
@brichet brichet deleted the do_not_raise_if_manager_disabled branch May 21, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants