Skip to content

Do not throw if the secrets manager is disabled #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Do not throw if the secrets manager is disabled #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2b5541
Do not throw if secrets manager is disabled
brichet May 20, 2025
d56564d
Throw error only if the message is provided
brichet May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,10 @@ export namespace SecretsManager {
throw new Error('Secrets manager is locked, check errors.');
}
if (isDisabled('jupyter-secrets-manager:manager')) {
lock('Secret registry is disabled.');
// If the secrets manager is disabled, we need to lock the manager, but not
// throw an error, to let the plugin get activated anyway.
console.warn('Secrets manager is disabled.');
lock();
}
if (isDisabled(id)) {
lock(`Sign error: plugin ${id} is disabled.`);
Expand Down Expand Up @@ -293,9 +296,11 @@ namespace Private {
*
* @param message - the error message to throw.
*/
export function lock(message: string) {
export function lock(message?: string): void {
locked = true;
throw new Error(message);
if (message) {
throw new Error(message);
}
}

/**
Expand Down
Loading