Beta to master #18884
Merged
Beta to master #18884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request updates translations to languages being tracked from Crowdin. Co-authored-by: GitHub Actions <>
### Link to issue number: Fixes #18867 ### Summary of the issue: Documentation is getting built after the signing request, causing it to not be included in the launcher. This caused the zh_TW (last docs file) to not be included in some beta builds ### Description of user facing changes: None ### Description of developer facing changes: - Release builds may now take longer - All builds including PR builds, snapshots, etc should safely contain all docs files ### Description of development approach: * Refactored SCons parallelism: Added a new `sconsCores` variable in `setSconsArgs.ps1` to control the number of build cores, defaulting to `--all-cores` except for debug or release builds, which use `-j1` for easier log parsing and debugging. * Updated workflow steps in `.github/workflows/testAndPublish.yml` to use the new `sconsCores` variable instead of inline logic for core selection, simplifying the build commands. [[1]](diffhunk://#diff-0228131759fc72c25ae13bc75628d794ff96d8aadef8aa21252bd315e3279b51L105-R105) [[2]](diffhunk://#diff-0228131759fc72c25ae13bc75628d794ff96d8aadef8aa21252bd315e3279b51L349-R351) * Added export and logging of `sconsCores` to the environment and output in `setSconsArgs.ps1`, improving transparency of build configuration in CI logs. * Removed `launcher` from the default `sconsOutTargets` in `setSconsArgs.ps1` and added a separate workflow step to build the launcher after other targets, preventing unsafe parallel builds of the launcher. [[1]](diffhunk://#diff-e627d750c249f53caef3ae05f40cd965a7e53632247af4328c3e9683884cf906L2-R13) [[2]](diffhunk://#diff-0228131759fc72c25ae13bc75628d794ff96d8aadef8aa21252bd315e3279b51L349-R351) * appx snippet removed as per #18799
Fixes #18853 Summary of the issue: pymdownx is a markdown extension we use to preserve tabs in codefenced code samples. It is missing from being exported with l10nUtil. This results in the l10nUtil being broken. Description of user facing changes: l10nUtil.exe works again Description of developer facing changes: None Description of development approach: Add pymdownx to exports for l10nUtil.exe
There was a problem hiding this comment.
Pull Request Overview
This pull request merges the beta branch into the master branch, containing various translation updates and minor corrections across multiple localization files. The primary focus is on finalizing translations and fixing state transitions from "translated" to "final" status.
Key Changes
- Translation state updates from "translated" to "final" for multiple language files
- Minor text corrections and refinements in Chinese, Traditional Chinese, Turkish, Tamil, and Serbian translations
- Consistency improvements in terminology and phrasing across documentation
Reviewed Changes
Copilot reviewed 87 out of 87 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/zh_TW/userGuide.xliff | Updates segment states to final and makes minor text refinements in Traditional Chinese |
| user_docs/zh_CN/userGuide.xliff | Corrects various Chinese phrases and terminology for better clarity |
| user_docs/zh_CN/changes.xliff | Updates translation states and fixes minor terminology issues |
| user_docs/tr/userGuide.xliff | Transitions multiple segments from initial to final state with Turkish translations |
| user_docs/tr/changes.xliff | Finalizes Turkish translations for changelog entries |
| user_docs/ta/userGuide.xliff | Minor terminology corrections in Tamil translations |
| user_docs/sr/userGuide.xliff | Completes Serbian translations and updates segment states |
Comments suppressed due to low confidence (6)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.