Breadcrumbs fix #628
Merged
Breadcrumbs fix #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d8014c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emilybrick
temporarily deployed
to
github-pages
GitHub Actions
Inactive
emilybrick
temporarily deployed
to
github-pages
GitHub Actions
Inactive
camertron
approved these changes
Aug 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breadcrumbs links are broken right now on primer.style/design. Testing a fix over in /design/ primer/design#566
Current:
Clicking on the breadcrumb links will 404, the URL is missing
/design/(see example by clicking on CLI in the breadcrumb https://primer.style/design/native/cli/getting-started)Expected:
The breadcrumb URL should direct to primer.style/design/
path, not primer.style/path