Skip to content

Breadcrumbs fix #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Breadcrumbs fix #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2aad480
breadcrumbs fix
emilybrick Aug 23, 2023
452d2b6
Merge branch 'main' into breadcrumbs-fix
emilybrick Aug 23, 2023
7d3fb6b
fix curly brackets on import
emilybrick Aug 24, 2023
1d8014c
Create moody-carrots-know.md
emilybrick Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/moody-carrots-know.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/gatsby-theme-doctocat": patch
---

- Add withPrefix to breadcrumbs
3 changes: 2 additions & 1 deletion theme/src/components/layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import StorybookLink from './storybook-link'
import FigmaLink from './figma-link'
import TableOfContents from './table-of-contents'
import navItems from '../nav.yml'
import {withPrefix} from 'gatsby'

const getPageAncestry = (url, object) => {
const result = []
Expand Down Expand Up @@ -112,7 +113,7 @@ function Layout({children, pageContext, path}) {
{breadcrumbData.length > 1 ? (
<Breadcrumbs sx={{mb: 4}}>
{breadcrumbData.map(item => (
<Breadcrumbs.Item key={item.url} href={item.url} selected={path === item.url}>
<Breadcrumbs.Item key={item.url} href={withPrefix(item.url)} selected={path === item.url}>
{item.title}
</Breadcrumbs.Item>
))}
Expand Down