Skip to content

Conversation

liuliu-dev
Copy link
Contributor

@liuliu-dev liuliu-dev commented Sep 3, 2025

docs update only.
Closes #5825

sx usage: 0

Rollout strategy

  • Patch release

Copy link

changeset-bot bot commented Sep 3, 2025

🦋 Changeset detected

Latest commit: 403eacf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 3, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.92 KB (0%)
packages/react/dist/browser.umd.js 88.07 KB (0%)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated sx prop from the SkeletonBox component's documentation as part of cleaning up deprecated styling APIs. The change is documentation-only and removes a prop that was already marked as deprecated.

  • Removes the deprecated sx prop from SkeletonBox component documentation
  • Adds a changeset entry documenting the removal as a patch release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/Skeleton/SkeletonBox.docs.json Removes the deprecated sx prop from the component's prop documentation
.changeset/metal-badgers-joke.md Adds changeset entry for the sx prop removal

@@ -0,0 +1,5 @@
---
'@primer/react': patch
Copy link
Preview

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the PR description, this should be a major release since it's marked as 'Major release' in the rollout strategy, but the changeset indicates a patch release. This inconsistency should be resolved.

Copilot generated this review using guidance from repository custom instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated description.

@liuliu-dev liuliu-dev added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit 6def61e Sep 9, 2025
44 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/remove-sx-from-SkeletonBox branch September 9, 2025 17:36
@primer primer bot mentioned this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants