-
Notifications
You must be signed in to change notification settings - Fork 628
Remove sx from the SkeletonBox component #6715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 403eacf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated sx
prop from the SkeletonBox component's documentation as part of cleaning up deprecated styling APIs. The change is documentation-only and removes a prop that was already marked as deprecated.
- Removes the deprecated
sx
prop from SkeletonBox component documentation - Adds a changeset entry documenting the removal as a patch release
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/src/Skeleton/SkeletonBox.docs.json | Removes the deprecated sx prop from the component's prop documentation |
.changeset/metal-badgers-joke.md | Adds changeset entry for the sx prop removal |
@@ -0,0 +1,5 @@ | |||
--- | |||
'@primer/react': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the PR description, this should be a major release since it's marked as 'Major release' in the rollout strategy, but the changeset indicates a patch release. This inconsistency should be resolved.
Copilot generated this review using guidance from repository custom instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated description.
docs update only.
Closes #5825
sx usage: 0
Rollout strategy