Skip to content

Remove sx from the SkeletonBox component #6715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 9, 2025
Merged

Remove sx from the SkeletonBox component #6715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e32a802
remove sx
liuliu-dev Sep 3, 2025
8f528f6
changeset
liuliu-dev Sep 3, 2025
2a6ef1b
Merge branch 'main' into liuliu/remove-sx-from-SkeletonBox
liuliu-dev Sep 8, 2025
403eacf
major->patch for docs update
liuliu-dev Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-badgers-joke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
Copy link
Preview

Copilot AI Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the PR description, this should be a major release since it's marked as 'Major release' in the rollout strategy, but the changeset indicates a patch release. This inconsistency should be resolved.

Copilot generated this review using guidance from repository custom instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated description.

---

Remove sx from the SkeletonBox component.
7 changes: 1 addition & 6 deletions packages/react/src/Skeleton/SkeletonBox.docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,7 @@
"type": "string",
"description": "The className of the skeleton box",
"defaultValue": ""
},
{
"name": "sx",
"type": "SystemStyleObject",
"deprecated": true
}
],
"subcomponents": []
}
}
Loading