You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an ADR for our strategy around shipping @primer/styled-react. Hopefully this captures our current thinking around this space, let me know what you think or if it would be helpful to include any additional information!
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds an Architecture Decision Record (ADR) documenting the strategy for creating a new @primer/styled-react package. This package will serve as a compatibility layer for teams still using styled-components while allowing the main @primer/react package to migrate to CSS Modules.
Key Changes
Documents the decision to create @primer/styled-react as a pre-1.0 package that re-exports components with sx prop support
Establishes deprecation strategy and migration path away from styled-components
Outlines consequences including increased package maintenance overhead and potential prolonged styled-components usage
skip changesetThis change does not need a changelogstaffAuthor is a staff member
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joshblack
requested review from
jonrohan,
pksjce,
siddharthkp,
liuliu-dev,
TylerJDev,
francinelucca,
llastflowers and
Copilot
github-actions
bot
requested a deployment
to
storybook-preview-6722
Closes https://github.com/github/primer/issues/5829
Adds an ADR for our strategy around shipping
@primer/styled-react. Hopefully this captures our current thinking around this space, let me know what you think or if it would be helpful to include any additional information!