pr05 Typescript #8: migrate client/components/Menubar/MenubarSubmenu

[clairep94]

pr05 Typescript Migration 8: Migrate the client/components/Menubar/MenubarSubmenu

Context:

• Had difficulty migrating/understanding MenubarSubmenu when building PR 7, so chose to open a PR without this file and to resolve it separately.
• Should be reviewed after pr05 Typescript Migration #7: migrate client components #3619 is merged for clarity.

Changes:

• Menubar/MenubarSubmenu
• Menubar/contexts

Other:

• any updates to use named exports

Notes:

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[clairep94]

@khanniie I'm not 100% if this was the correct approach

I was a bit confused because the original file had the below:

MenubarTrigger.propTypes = {
  role: PropTypes.string,
  hasPopup: PropTypes.oneOf(['menu', 'listbox', 'true'])
};

MenubarList.propTypes = {
  children: PropTypes.node,
  role: PropTypes.oneOf(['menu', 'listbox'])
};

I made the assumption the menu bar list item roles and menubar trigger aria-hasPopup are associated in the relationship defined in the enums??
Should we just remove TRUE? I didn't see TRUE being used elsewhere

[clairep94]

wasn't sure how to resolve this other than casting, but I thought was safe bc this function is only used within this file once and it's always a button ref

[clairep94]

not sure if string is too loose here, or if there is a specific enum we should be using?

[clairep94]

@raclim @khanniie ready for review! this is build off of PR 7, which was big so might be best to wait till PR 7 is merged to look at this one