Skip to content

pr05 Typescript #8: migrate client/components/Menubar/MenubarSubmenu #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
+219 −180
Open

pr05 Typescript #8: migrate client/components/Menubar/MenubarSubmenu #3623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6485550
MenubarSubmenu: update to tsx, no-verify
clairep94 Sep 1, 2025
839a8aa
MenubarSubmenu: wip add interface --no-verify
clairep94 Sep 1, 2025
ff0100b
merge with pr05/Migrate_client_components_final_rebuild
clairep94 Sep 3, 2025
632c11a
MenubarSubmenu: update context interfaces, wip, no-verify
clairep94 Sep 3, 2025
d8327b5
MenubarSubmenu: define interfaces, no-verify
clairep94 Sep 3, 2025
1127755
MenubarSubmenu: update to named export, no-verify for remaining ts er…
clairep94 Sep 3, 2025
913d9e6
MenubarSubmenu: cast ref prop as RefObject to resolve typeerror in Me…
clairep94 Sep 3, 2025
2427c1f
MenubarSubmenu: fix final typeerrors by adding htmlElement check
clairep94 Sep 3, 2025
168a9e5
Merge branch 'develop' into pr05/Migrate_client_components_final_rebu…
clairep94 Sep 4, 2025
4e993cf
MenubarSubmenu: update to address feedback for MenuContainerRole
clairep94 Sep 15, 2025
eef7fe0
MenubarSubmenu: add enum for menubar list item roles
clairep94 Sep 15, 2025
1f200da
Merge branch 'develop' into pr05/Migrate_client_components_final_rebu…
clairep94 Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/components/Menubar/Menubar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { render, screen, fireEvent } from '../../test-utils';
import { Menubar } from './Menubar';
import MenubarSubmenu from './MenubarSubmenu';
import { MenubarSubmenu } from './MenubarSubmenu';
import { MenubarItem } from './MenubarItem';

describe('Menubar', () => {
Expand Down
Loading
Loading