Skip to content

editor contrast issue (#3579) #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

editor contrast issue (#3579) #3634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ GITHUB_ID=<your-github-client-id>
GITHUB_SECRET=<your-github-client-secret>
GOOGLE_ID=<your-google-client-id> (use google+ api)
GOOGLE_SECRET=<your-google-client-secret> (use google+ api)
MAILGUN_DOMAIN=<your-mailgun-domain>
MAILGUN_KEY=<your-mailgun-api-key>
MAILGUN_DOMAIN=<your-maiaasxslgun-domain>
MAILGUN_KEY=<your-mailgxasxasxun-key>
ML5_LIBRARY_USERNAME=ml5
[email protected]
ML5_LIBRARY_PASS=helloml5
MONGO_URL=mongodb://localhost:27017/p5js-web-editor
MONGO_URL=mongodb+srv://jeelrupareliya255:[email protected]/
PORT=8000
PREVIEW_PORT=8002
EDITOR_URL=http://localhost:8000
Expand Down
31 changes: 16 additions & 15 deletions client/styles/abstracts/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
$base-font-size: 12;

//colors

$p5js-pink: #ed225d;
$p5js-pink-text: #C11245;
$p5js-pink-opacity: #ed225d80;
$p5js-active-pink: #f10046;
$white: #fff;
Expand All @@ -12,17 +13,17 @@ $p5-contrast-pink: #FFA9D9;

$outline-color: #0F9DD7;

// Grayscale values
$lightest: #FFF; // primary

$lightest: #FFF;
$lighter: #FBFBFB;

$light: #F0F0F0; // primary
$light: #F0F0F0;
$medium-light: #D9D9D9;
$middle-light: #A6A6A6;

// $middle-gray: #7D7D7D; // primary
$middle-gray: #747474; // primary
$middle-dark: #666;

$middle-gray: #747474;
$middle-dark: #666;
$medium-dark: #4D4D4D;

$dark: #333; // primary
Expand All @@ -42,7 +43,7 @@ $themes: (
button-background-color: $light,
button-secondary-background-color: $medium-light,
button-color: $black,
button-border-color: $middle-light,
button-border-color: $middle-dark,
toolbar-button-color: $dark,
toolbar-button-background-color: $medium-light,
button-background-hover-color: $p5js-pink,
Expand All @@ -52,7 +53,7 @@ $themes: (
button-active-color: $lightest,
modal-background-color: $light,
preferences-button-background-color: $medium-light,
modal-border-color: $middle-light,
modal-border-color: $middle-dark,
icon-color: $middle-gray,
icon-hover-color: $darker,
icon-toast-hover-color: $lightest,
Expand All @@ -64,7 +65,7 @@ $themes: (
console-active-arrow-color: #0071AD,
console-header-background-color: $medium-light,
console-header-color: $darker,
ide-border-color: $medium-light,
ide-border-color: $middle-dark,
editor-gutter-color: $lighter,
file-hover-color: $light,
file-selected-color: $medium-light,
Expand All @@ -73,14 +74,14 @@ $themes: (
input-secondary-background-color: $lightest,
input-selection-text-color: $dark,
input-selection-background-color: $medium-light,
input-border-color: $middle-light,
input-border-color: $middle-dark,
search-background-color: $lightest,
search-clear-background-color: $light,
search-hover-text-color: $lightest,
search-hover-background-color: $medium-dark,
keyboard-shortcut-color: $middle-gray,
nav-hover-color: $p5js-pink,
nav-border-color: $middle-light,
nav-border-color: $middle-dark,
error-color: $p5js-pink,
table-row-stripe-color: $medium-light,
table-row-stripe-color-alternate: $medium-light,
Expand All @@ -95,8 +96,8 @@ $themes: (
table-button-hover-color: $lightest,
table-button-background-hover-color: $p5js-pink,

progress-bar-background-color: $middle-gray,
progress-bar-active-color: $p5js-active-pink,
progress-bar-background-color: $light,
progress-bar-active-color: $p5js-pink,

form-title-color: rgba(51, 51, 51, 0.87),
form-secondary-title-color: $medium-dark,
Expand Down Expand Up @@ -174,7 +175,7 @@ $themes: (
input-secondary-background-color: $medium-dark,
input-selection-text-color: $darkest,
input-selection-background-color: $lightest,
input-border-color: $middle-dark,
input-border-color: $light, // Improved from $middle-dark for better contrast in dark theme
search-background-color: $darker,
search-clear-background-color: $medium-dark,
search-hover-text-color: $lightest,
Expand Down