Standard input/output support 1: stream RRD data from stdin #4511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🧑💻 dev experience
This was referenced Dec 13, 2023
teh-cmc
commented
Dec 13, 2023
teh-cmc
force-pushed
the
cmc/stdio_1_viewer
branch
3 times, most recently
from
ffd439b to
c2b3750
Compare
teh-cmc
force-pushed
the
cmc/stdio_1_viewer
branch
from
c2b3750 to
634f7ff
Compare
teh-cmc
commented
Dec 14, 2023
| @@ -101,6 +101,7 @@ array-init = "2.1" | |||
| arrow2 = "0.17" | |||
| arrow2_convert = "0.5.0" | |||
| async-executor = "1.0" | |||
| atty = "0.2" | |||
There was a problem hiding this comment.
future truth: used in upcoming PRs.
Wumpf
approved these changes
Dec 14, 2023
teh-cmc
added a commit
that referenced
this pull request
Dec 14, 2023
…4514) Allow the C++ SDK to stream RRD data to stdout. Checks: - [x] `just py-build && just cpp-build-examples && echo 'hello from stdin!' | ./build/debug/examples/cpp/stdio/example_stdio | rerun -` --- Part of a small PR series to add stdio streaming support to our Viewer and SDKs: - #4511 - #4512 - #4513 - #4514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
stdinsource to the viewer so it can stream data in from standard input.We make
stdinan explicit input (rerun -) like in the good old days, to avoid shady behavior in non-TTY and other esoteric environment (crazy WSL setups, etc). Trust me, it gets quite insane...Checks:
rerunworksrerun -blocksrerun - < data.rrdworkscat data.rrd | rerun -worksrerun < data.rrdworks but does nothingcat data.rrd | rerunworks but does nothingPart of a small PR series to add stdio streaming support to our Viewer and SDKs:
Checklist