Skip to content

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Dec 13, 2023

Allow the Python SDK to stream RRD data to stdout.

Checks:

  • just py-build && echo 'hello from stdin!' | python examples/python/stdio/main.py | rerun -

Part of a small PR series to add stdio streaming support to our Viewer and SDKs:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
    • Full build: app.rerun.io
    • Partial build: app.rerun.io - Useful for quick testing when changes do not affect examples in any way
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Dec 14, 2023
teh-cmc added a commit that referenced this pull request Dec 14, 2023
Add a `stdin` source to the viewer so it can stream data in from
standard input.

We make `stdin` an explicit input (`rerun -`) like in the good old days,
to avoid shady behavior in non-TTY and other esoteric environment (crazy
WSL setups, etc). Trust me, it gets quite insane...

Checks:
- [x] `rerun` works
- [x] `rerun -` blocks
- [x] `rerun - < data.rrd` works
- [x] `cat data.rrd | rerun -` works
- [x] `rerun < data.rrd` works but does nothing
- [x] `cat data.rrd | rerun` works but does nothing
- [x] no-TTY & other esoteric environments don't go completely off the
rails

---

Part of a small PR series to add stdio streaming support to our Viewer
and SDKs:
- #4511
- #4512 
- #4513
- #4514
Base automatically changed from cmc/stdio_2_rust to main December 14, 2023 17:13
teh-cmc added a commit that referenced this pull request Dec 14, 2023
…4512)

Allow the Rust SDK to stream RRD data to stdout.

Checks:
- [x] `just py-build && echo 'hello from stdin!' | cargo run -p stdio |
rerun -`

---

Part of a small PR series to add stdio streaming support to our Viewer
and SDKs:
- #4511
- #4512 
- #4513
- #4514
@teh-cmc teh-cmc merged commit da466ee into main Dec 14, 2023
@teh-cmc teh-cmc deleted the cmc/stdio_3_python branch December 14, 2023 17:14
teh-cmc added a commit that referenced this pull request Dec 14, 2023
…4514)

Allow the C++ SDK to stream RRD data to stdout.

Checks:
- [x] `just py-build && just cpp-build-examples && echo 'hello from
stdin!' | ./build/debug/examples/cpp/stdio/example_stdio | rerun -`

---

Part of a small PR series to add stdio streaming support to our Viewer
and SDKs:
- #4511
- #4512 
- #4513
- #4514
@teh-cmc teh-cmc mentioned this pull request Dec 14, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) include in changelog sdk-python Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants