test: remove outdated TODO comment in createTable spec
#1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
breaking change
|
There is an e2e migration test failing 🤔 |
node-pg-migrate/test/migrations/069_comments.js Lines 1 to 4 in 795f9e8 it will produce this sql CREATE TABLE "test-comment" (
);
COMMENT ON TABLE "test-comment" IS $pga$table's comment$pga$;
DROP TABLE "test-comment";I ran it manually and tables with no columns are valid so I think we should just remove the TODO instead? |
So it is valid for: "just create the table"? 😲 |
brenoepics
changed the title
createTable spec
Shinigami92
changed the title
createTable speccreateTable spec
Shinigami92
approved these changes
Jul 15, 2025
brenoepics
added a commit
to brenoepics/node-pg-migrate
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.