Skip to content

test: remove outdated TODO comment in createTable spec #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2025
Merged

test: remove outdated TODO comment in createTable spec #1466

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0aa8e64
fix: throw error when no options are provided in createTable
brenoepics Jul 13, 2025
13ed5a8
Revert "fix: throw error when no options are provided in createTable"
brenoepics Jul 15, 2025
e58b405
chore(tests): remove outdated TODO comment in createTable spec
brenoepics Jul 15, 2025
7107c41
Merge branch 'main' into fix-create-table
brenoepics Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/operations/tables/createTable.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ describe('operations', () => {
expect(createTableFn).toBeTypeOf('function');
});

// TODO @Shinigami92 2024-03-12: This should throw an error when columns are empty
it('should return sql statement', () => {
const statement = createTableFn('films', {});

Expand Down