allow empty auth definitions in parser

[spolti]

fixes #110

Signed-off-by: spolti [email protected]

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

Special notes for reviewers:

Additional information (if needed):

[lsytj0413]

The problem is not cause by AuthDefinitions.Unmarshal implement, according to the specificaiton, auth field is an array of object, which like:

But in the source code, we place an Defs field under Auth Definition struct. So after we marshal object to json, it looks like:

{
	"id": "applicantrequest",
	"name": "Applicant Request Decision Workflow",
	"description": "Determine if applicant request is valid",
	"version": "1.0",
	"start": {
		"stateName": "CheckApplication"
	},
	"specVersion": "0.7",
	"expressionLang": "jq",
	"auth": {
		"Defs": [{
			"name": "testAuth",
			"scheme": "bearer",
			"properties": {
				"token": "test_token"
			}
		}, {
			"name": "testAuth2",
			"scheme": "basic",
			"properties": {
				"username": "test_user",
				"password": "test_pwd"
			}
		}]
	},
	"states": [{
		"name": "CheckApplication",
		"type": "switch",
		"defaultCondition": {},
		"dataConditions": [{
			"condition": "${ .applicants | .age \u003e= 18 }",
			"transition": {
				"nextState": "StartApplication"
			}
		}, {
			"condition": "${ .applicants | .age \u003c 18 }",
			"transition": {
				"nextState": "RejectApplication"
			}
		}],
		"timeouts": {}
	}, {
		"name": "StartApplication",
		"type": "operation",
		"end": {
			"terminate": true
		},
		"actions": [{
			"subFlowRef": {
				"workflowId": "startApplicationWorkflowId",
				"invoke": "sync",
				"onParentComplete": "terminate"
			},
			"sleep": {},
			"actionDataFilter": {
				"useResults": true
			}
		}]
	}, {
		"name": "RejectApplication",
		"type": "operation",
		"end": {
			"terminate": true
		},
		"actionMode": "sequential",
		"actions": [{
			"functionRef": {
				"refName": "sendRejectionEmailFunction",
				"invoke": "sync"
			},
			"sleep": {},
			"actionDataFilter": {
				"useResults": true
			}
		}]
	}],
	"functions": [{
		"name": "sendRejectionEmailFunction",
		"operation": "http://myapis.org/applicationapi.json#emailRejection"
	}],
	"retries": [{
		"name": "TimeoutRetryStrategy",
		"delay": "PT1M",
		"maxAttempts": "5",
		"jitter": 0
	}]
}

It's not equivalent. I think we should fix the struct field layout.

[spolti]

needed for v08 #70

[spolti]

About the defs problem, there is another problem as well, see:

https://gist.github.com/spolti/ac43ce2cc5a51532987259db4f9fa5b7
Will address it on another issue: #126

[lsytj0413]

According to the specification, should we directly change this field's type to []Auth？

[spolti]

yes, tried already, the problem is, if we do that we can't have strings :)
maybe declaring it as interface might help, let's see..

[lsytj0413]

I think we can do it in this way.

// First, we redefine the []Auth
type AuthArray []Auth

// Second, change struct field
Auth AuthArray

// Third, define UnmarshalJSON for AuthArray, and implement it
func (a *AuthArray) UnmarshalJSON(data []byte) error {
// Unmarshal it as string or array
}

[spolti]

that could work.

[spolti]

I wasn't able to get it working with this approach, however with interface it is fully working, including the fix for this issue and #126

[spolti]

@davidesalerno f.y.i

[lsytj0413]

/lgtm