Skip to content

feat(template/helm): Allow Pod priorityClassName to be configured #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2025
Merged

feat(template/helm): Allow Pod priorityClassName to be configured #551

merged 4 commits into from
Sep 16, 2025

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Sep 16, 2025 •
edited
Loading

Part of stackabletech/issues#765.

  • Allow Pod priorityClassName to be configured.
  • Also disable rather useless yamllint lint. It would otherwise stop example values being added as comments.

Note: listener-operator and secret-operator will be excluded from this (since they have run-mode: custom), and will be rolled out in their own PRs.

Tip

When rolling out, update the changelogs before merging the PRs. Eg:

### Added

- Helm: Allow Pod `priorityClassName` to be configured ([#xxx]).

@NickLarsenNZ NickLarsenNZ self-assigned this Sep 16, 2025
@NickLarsenNZ NickLarsenNZ moved this to Development: In Progress in Stackable Engineering Sep 16, 2025
NickLarsenNZ added a commit to stackabletech/listener-operator that referenced this pull request Sep 16, 2025
@NickLarsenNZ
chore: Disable yamllint for comments-indentation
ebccce0 
This would be rolled out by stackabletech/operator-templating#551
@NickLarsenNZ NickLarsenNZ changed the title feat(template/helm): Allow Pod priority, priorityClassName, and preemptionPolicy to be configured feat(template/helm): Allow Pod priorityClassName to be configured Sep 16, 2025
@NickLarsenNZ
fix(template/helm): Remove priority and preemptionPolicy.
0e86593 
Note: These should be configured in a PriorityClass and the admission controller will stop you setting these on the pod directly.
@NickLarsenNZ
Copy link
Member Author

Tested (rendered nifi-operator). Found out the admission controller will not allow you to set priority and preemptionPolicy directly on a Pod. You must use a PriorityClass.

I have removed these.

@NickLarsenNZ NickLarsenNZ moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Sep 16, 2025
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Sep 16, 2025
@NickLarsenNZ NickLarsenNZ mentioned this pull request Sep 16, 2025
Open
17 tasks
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Sep 16, 2025
Merged via the queue into main with commit 9937fb4 Sep 16, 2025
2 checks passed
@NickLarsenNZ NickLarsenNZ deleted the allow-setting-pod-priority branch September 16, 2025 09:17
stackable-bot added a commit to stackabletech/kafka-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Generated commit to update templated files since the last temp…
17c5cda 
…late run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
stackable-bot added a commit to stackabletech/commons-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Generated commit to update templated files since the last temp…
de076c0 
…late run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
This was referenced Sep 16, 2025
Merged
Merged
stackable-bot added a commit to stackabletech/druid-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Generated commit to update templated files since the last temp…
adb2272 
…late run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
@stackable-bot stackable-bot mentioned this pull request Sep 16, 2025
Merged
stackable-bot added a commit to stackabletech/secret-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Generated commit to update templated files since the last temp…
8c497a8 
…late run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
@stackable-bot stackable-bot mentioned this pull request Sep 16, 2025
Merged
stackable-bot added a commit to stackabletech/superset-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Generated commit to update templated files since the last temp…
2139c78 
…late run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
@stackable-bot stackable-bot mentioned this pull request Sep 16, 2025
Merged
stackable-bot added a commit to stackabletech/airflow-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Generated commit to update templated files since the last temp…
451e155 
…late run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
@stackable-bot stackable-bot mentioned this pull request Sep 16, 2025
Merged
stackable-bot added a commit to stackabletech/nifi-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Generated commit to update templated files since the last temp…
0f0ec3e 
…late run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
stackable-bot added a commit to stackabletech/listener-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Generated commit to update templated files since the last temp…
6777b8a 
…late run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
This was referenced Sep 16, 2025
Merged
Merged
stackable-bot added a commit to stackabletech/hbase-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Generated commit to update templated files since the last temp…
a9d7ea8 
…late run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
@stackable-bot stackable-bot mentioned this pull request Sep 16, 2025
Merged
github-merge-queue bot pushed a commit to stackabletech/secret-operator that referenced this pull request Sep 16, 2025
@stackable-bot
feat(helm): Allow Pod priorityClassName to be configured (#639)
164780d 
chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
github-merge-queue bot pushed a commit to stackabletech/listener-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Disable yamllint lint for comment indentations (#335)
cadc336 
chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
github-merge-queue bot pushed a commit to stackabletech/commons-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#376)
6fe16bc 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/opa-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#762)
8315614 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/zookeeper-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#974)
056a6da 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/opensearch-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#34)
f62cbd1 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/superset-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#664)
306e38f 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
stackable-bot added a commit to stackabletech/spark-k8s-operator that referenced this pull request Sep 16, 2025
@stackable-bot
chore: Generated commit to update templated files since the last temp…
57c1b4d 
…late run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)
@stackable-bot stackable-bot mentioned this pull request Sep 16, 2025
Merged
github-merge-queue bot pushed a commit to stackabletech/trino-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#798)
a26ff20 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/nifi-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#840)
185f005 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/hbase-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#691)
201bc03 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/hive-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#633)
840c0a9 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/kafka-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#890)
3b23aa2 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/hdfs-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#713)
8b355f9 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/druid-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#752)
aebd7a4 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/airflow-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#687)
f7c50ac 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/spark-k8s-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#608)
f82d9a0 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/zookeeper-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#974)
b64fc0b 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/trino-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#798)
4cff1ba 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/superset-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#664)
cf5ee5d 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/nifi-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#840)
0a30bd2 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/commons-operator that referenced this pull request Sep 16, 2025
@stackable-bot @NickLarsenNZ
feat(helm): Allow Pod priorityClassName to be configured (#376)
636b8f2 
* chore: Generated commit to update templated files since the last template run up to stackabletech/operator-templating@9937fb4

Reference-to: stackabletech/operator-templating@9937fb4 (This allows Pod `priorityClassName` to be configured in operators (excluding listener-operator and secret-operator). It requires a CHANGELOG entry before merging (see example in <stackabletech/operator-templating#551>).)

* chore: Update changelog

---------

Co-authored-by: Nick Larsen <[email protected]>
github-merge-queue bot pushed a commit to stackabletech/listener-operator that referenced this pull request Sep 16, 2025
@NickLarsenNZ @Techassi
feat(helm)!: Allows for the CSI Provisioner Deployment and CSI Node D…
51f1219 
…river DaemonSet to be configured independently (#334)

* chore: Add docs to run modes

* chore(helm)!: Rename resources, labels, and containers

Note: This tries to align as well as possible to the rather scattered and vague CSI terminology.

The charts should be uninstalled and reinstalled to ensure no orphaned and conflicting resources remain.

This could impact monitoring setups that depend on the old resource names, labels, and container names.

* chore(helm)!: Use with to set context for the Deployment/DaemonSet.

BREAKING: Helm values that were under `csiNodeDriverRegistrar` are now under `csiNodeDriver`.
The reason being is that the "registrar" is only one of the containers in the DaemonSet for the Node Driver.

* chore(helm): Rename csi-provisioner deployment filename

* chore(helm)!: Separate configs for the Provisioner Deployment

* chore(helm)!: Separate configs for the NodeDriver DaemonSet

* chore(helm): Show example for overriding the operator image tag

* chore(helm): Remove "with" directive because Deployment/DaemonSet containers are not optional

NOTE: These were incorrectly introduced in 463592a while trying to hash out the structure of the values.

* feat(helm): Allow Pod priority, priorityClassName, and preemptionPolicy to be configured

* chore: Update changelog

* chore: Disable yamllint for comments-indentation

This would be rolled out by stackabletech/operator-templating#551

* fix(helm): Remove unconfigurable Pod fields

These were introduced in 010207b. Only priorityClassName is valid.

* chore: Update changelog

* fix(helm): Rename nodeRegistrar to nodeDriverRegistrar for consistency

* Apply suggestions from code review

Co-authored-by: Techassi <[email protected]>

---------

Co-authored-by: Techassi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
Stackable Engineering
Status: Development: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickLarsenNZ @Techassi