Skip to content

[ROCM][V0] PA kennel selection when no sliding window provided #15982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

[ROCM][V0] PA kennel selection when no sliding window provided #15982

merged 1 commit into from
Apr 3, 2025

Conversation

maleksan85
Copy link
Contributor

@maleksan85 maleksan85 commented Apr 3, 2025 •
edited by github-actions bot
Loading

Restoring correct PA kernel selection when sliding window is represented as (-1, -1), i.e. not provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) April 3, 2025 03:02
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 3, 2025
@robertgshaw2-redhat robertgshaw2-redhat merged commit 57a810d into vllm-project:main Apr 3, 2025
41 of 42 checks passed
@maleksan85 maleksan85 deleted the v0_restoring_correct_selection_of_rocm_pa branch April 3, 2025 05:30
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@maleksan85 @Alex4210987
[ROCM][V0] PA kennel selection when no sliding window provided (vllm-…
31dc9e3 
…project#15982)

Signed-off-by: Aleksandr Malyshev <[email protected]>
Co-authored-by: Aleksandr Malyshev <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@maleksan85 @lulmer
[ROCM][V0] PA kennel selection when no sliding window provided (vllm-…
99d507c 
…project#15982)

Signed-off-by: Aleksandr Malyshev <[email protected]>
Co-authored-by: Aleksandr Malyshev <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@divakar-amd divakar-amd mentioned this pull request Apr 10, 2025
Merged
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@maleksan85 @lk-chen
[ROCM][V0] PA kennel selection when no sliding window provided (vllm-…
5e9b8a1 
…project#15982)

Signed-off-by: Aleksandr Malyshev <[email protected]>
Co-authored-by: Aleksandr Malyshev <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@maleksan85 @shreyankg
[ROCM][V0] PA kennel selection when no sliding window provided (vllm-…
8ab24bf 
…project#15982)

Signed-off-by: Aleksandr Malyshev <[email protected]>
Co-authored-by: Aleksandr Malyshev <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@maleksan85
[ROCM][V0] PA kennel selection when no sliding window provided (vllm-…
27bd1de 
…project#15982)

Signed-off-by: Aleksandr Malyshev <[email protected]>
Co-authored-by: Aleksandr Malyshev <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maleksan85 @robertgshaw2-redhat