Upgrade xgrammar to 0.1.23 #22988
Upgrade xgrammar to 0.1.23 #22988
Conversation
https://github.com/mlc-ai/xgrammar/releases/tag/v0.1.23 Signed-off-by: Russell Bryant <[email protected]>
…lm-project#19565)" This reverts commit c57bb19. Signed-off-by: Russell Bryant <[email protected]>
russellb
requested review from
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades xgrammar to version 0.1.23 and reverts a workaround related to concurrent structured output requests. The changes are straightforward: the dependency version is updated in requirements/common.txt, and in vllm/v1/worker/gpu_model_runner.py, the code is simplified by removing the forced use of a specific xgrammar kernel implementation. This is done under the assumption that the new xgrammar version fixes the underlying issue, as stated in the pull request description. The code changes are consistent with this goal and appear correct. I have no further comments.
|
Sweet! |
* 'main' of https://github.com/845473182/vllm: (457 commits) [BugFix] Fix routed_scaling_factor double mul for dots1 and glm4 MoE models (vllm-project#24132) [Misc] Add check for dual_chunk_attention (vllm-project#24070) [Doc]: fix typos in Python comments (vllm-project#24115) [Doc]: fix typos in Python comments (vllm-project#24093) [Compile] Fix Compile Warning for `w4a8_mm_entry.cu` (vllm-project#23660) fix some typos (vllm-project#24071) [V1] Wrapper which plumbs request-level logits processors into vLLM batch-level logits processing (vllm-project#23656) Upgrade xgrammar to 0.1.23 (vllm-project#22988) Update release pipeline post PyTorch 2.8.0 update (vllm-project#24073) [XPU] Fix the bug of LoRA logits on the XPU platform (vllm-project#24081) [CI/Build] Disable SiluMul NVFP4 quant fusion tests (vllm-project#24121) [Bug] R1 Accuracy: Fix `routed_scaling_factor` Double Mul Issue (vllm-project#24119) [AMD][Kernel][Bugfix] Cast offsets tensor bn to tl.int64 to avoid GPU segfault (vllm-project#23692) [CI] Enable all hf transformers baselines in test_hybrid (vllm-project#23936) [Log] Only Print Profiler Results on Rank 0 (vllm-project#23370) Fix weights loading for Apertus (vllm-project#24100) [Metrics] Deprecate TPOT in favor of ITL (vllm-project#24110) [Bugfix] Fix packed_factor missing attribute error (vllm-project#23902) Run ruff format on a few files. (vllm-project#24075) [Bugfix] Fix transform_config parsing in Compressed Tensors (vllm-project#23945) ...
Signed-off-by: Russell Bryant <[email protected]> Signed-off-by: Shiyan Deng <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
Upgrade Xgrammar to 0.1.23, which includes some important fixes which allow us
to revert the workaround introduced by #19565.