[Misc] Add check for dual_chunk_attention #24070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zjy0516 <[email protected]>
ZJY0516
requested review from
simon-mo,
WoosukKwon,
youkaichao,
robertgshaw2-redhat,
mgoin,
tlrmchlsmth,
houseroad,
hmellor,
yewentao256 and
ProExpertProg
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a validation check to ensure that VLLM_ATTENTION_BACKEND is set to DUAL_CHUNK_FLASH_ATTN for Qwen2.5 models, which is a great improvement for user experience by catching misconfigurations early. My feedback focuses on improving the robustness of this check by using a ValueError instead of an assert statement.
Signed-off-by: zjy0516 <[email protected]>
LucasWilkinson
approved these changes
Sep 3, 2025
github-actions
bot
added
the
ready
845473182
pushed a commit
to 845473182/vllm
that referenced
this pull request
Sep 3, 2025
* 'main' of https://github.com/845473182/vllm: (457 commits) [BugFix] Fix routed_scaling_factor double mul for dots1 and glm4 MoE models (vllm-project#24132) [Misc] Add check for dual_chunk_attention (vllm-project#24070) [Doc]: fix typos in Python comments (vllm-project#24115) [Doc]: fix typos in Python comments (vllm-project#24093) [Compile] Fix Compile Warning for `w4a8_mm_entry.cu` (vllm-project#23660) fix some typos (vllm-project#24071) [V1] Wrapper which plumbs request-level logits processors into vLLM batch-level logits processing (vllm-project#23656) Upgrade xgrammar to 0.1.23 (vllm-project#22988) Update release pipeline post PyTorch 2.8.0 update (vllm-project#24073) [XPU] Fix the bug of LoRA logits on the XPU platform (vllm-project#24081) [CI/Build] Disable SiluMul NVFP4 quant fusion tests (vllm-project#24121) [Bug] R1 Accuracy: Fix `routed_scaling_factor` Double Mul Issue (vllm-project#24119) [AMD][Kernel][Bugfix] Cast offsets tensor bn to tl.int64 to avoid GPU segfault (vllm-project#23692) [CI] Enable all hf transformers baselines in test_hybrid (vllm-project#23936) [Log] Only Print Profiler Results on Rank 0 (vllm-project#23370) Fix weights loading for Apertus (vllm-project#24100) [Metrics] Deprecate TPOT in favor of ITL (vllm-project#24110) [Bugfix] Fix packed_factor missing attribute error (vllm-project#23902) Run ruff format on a few files. (vllm-project#24075) [Bugfix] Fix transform_config parsing in Compressed Tensors (vllm-project#23945) ...
842974287
pushed a commit
to 842974287/vllm
that referenced
this pull request
Sep 3, 2025
Signed-off-by: zjy0516 <[email protected]> Signed-off-by: Shiyan Deng <[email protected]>
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
Signed-off-by: zjy0516 <[email protected]>
LopezCastroRoberto
pushed a commit
to LopezCastroRoberto/vllm
that referenced
this pull request
Sep 11, 2025
Signed-off-by: zjy0516 <[email protected]> Signed-off-by: LopezCastroRoberto <[email protected]>
cboss6
pushed a commit
to cboss6/vllm
that referenced
this pull request
Sep 16, 2025
Signed-off-by: zjy0516 <[email protected]> Signed-off-by: bruceszchen <[email protected]>
cboss6
pushed a commit
to cboss6/vllm
that referenced
this pull request
Sep 16, 2025
Signed-off-by: zjy0516 <[email protected]> Signed-off-by: bruceszchen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
FIX #24048
Add an early validation check for the
DUAL_CHUNK_FLASH_ATTNenvironment variable when using theQwen2.5-14B-Instruct-1M model. This preemptive check should trigger a clear error on startup rather than allowing the code to fail later and obscurely within the attention module.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.