Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 21, 2025

Backport of #10934 to release/9.4

/cc @sebastienros

Customer Impact

Users can't resolve the model if the resource and model names don't match.

Testing

Unit testing and manual testing.
Deployed from the dashboard and using azd.

Risk

Low.

Regression?

No, new feature in 9.4

@sebastienros sebastienros added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 21, 2025
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 21, 2025
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eerhardt
Copy link
Member

Make sure to forward port this change back to main.

This was referenced Sep 8, 2025
vgmello added a commit to vgmello/momentum that referenced this pull request Sep 9, 2025
[//]: # (dependabot-start)
⚠️  **Dependabot is rebasing this PR** ⚠️ 

Rebasing might not happen immediately, so don't worry if this takes some
time.

Note: if you make any changes to this PR yourself, they will take
precedence over the rebase.

---

[//]: # (dependabot-end)

Updated
[Microsoft.Extensions.ServiceDiscovery](https://github.com/dotnet/aspire)
from 9.4.1 to 9.4.2.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.Extensions.ServiceDiscovery's
releases](https://github.com/dotnet/aspire/releases)._

## 9.4.2

## What's Changed
* [release/9.4] Simplify Aspire CLI project name validation to only
reject path separators by @​github-actions[bot] in
dotnet/aspire#10832
* [release/9.4] External Services with URL Parameter fails to generate
manifests by @​github-actions[bot] in
dotnet/aspire#10806
* [release/9.4] Always update resource list in console logs after hidden
bool changes by @​github-actions[bot] in
dotnet/aspire#10738
* [release/9.4] serve blazor.web.js from wwwroot by @​JamesNK in
dotnet/aspire#10990
* Branding updates for 9.4.2 by @​joperezr in
dotnet/aspire#11026
* [release/9.4] Port Fix creating projects with GB18030 chars by
@​danmoseley in dotnet/aspire#11032
* [release/9.4] Fix Azure AI Foundry resource name by
@​github-actions[bot] in dotnet/aspire#11038
* [release/9.4] Fixed properties override when publishing an update in
external service by @​github-actions[bot] in
dotnet/aspire#10824


**Full Changelog**:
dotnet/aspire@v9.4.1...v9.4.2

Commits viewable in [compare
view](dotnet/aspire@v9.4.1...v9.4.2).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.Extensions.ServiceDiscovery&package-manager=nuget&previous-version=9.4.1&new-version=9.4.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vitor M <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants