-
Notifications
You must be signed in to change notification settings - Fork 685
[release/9.4] Fix Azure AI Foundry resource name #11038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
approved these changes
Aug 21, 2025
eerhardt
reviewed
Aug 21, 2025
src/Aspire.Hosting.Azure.AIFoundry/AzureAIFoundryDeploymentResource.cs
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
Aug 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Make sure to forward port this change back to |
This was referenced Sep 3, 2025
This was referenced Sep 8, 2025
Closed
Closed
Open
vgmello
added a commit
to vgmello/momentum
that referenced
this pull request
Sep 9, 2025
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Updated [Microsoft.Extensions.ServiceDiscovery](https://github.com/dotnet/aspire) from 9.4.1 to 9.4.2. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Extensions.ServiceDiscovery's releases](https://github.com/dotnet/aspire/releases)._ ## 9.4.2 ## What's Changed * [release/9.4] Simplify Aspire CLI project name validation to only reject path separators by @github-actions[bot] in dotnet/aspire#10832 * [release/9.4] External Services with URL Parameter fails to generate manifests by @github-actions[bot] in dotnet/aspire#10806 * [release/9.4] Always update resource list in console logs after hidden bool changes by @github-actions[bot] in dotnet/aspire#10738 * [release/9.4] serve blazor.web.js from wwwroot by @JamesNK in dotnet/aspire#10990 * Branding updates for 9.4.2 by @joperezr in dotnet/aspire#11026 * [release/9.4] Port Fix creating projects with GB18030 chars by @danmoseley in dotnet/aspire#11032 * [release/9.4] Fix Azure AI Foundry resource name by @github-actions[bot] in dotnet/aspire#11038 * [release/9.4] Fixed properties override when publishing an update in external service by @github-actions[bot] in dotnet/aspire#10824 **Full Changelog**: dotnet/aspire@v9.4.1...v9.4.2 Commits viewable in [compare view](dotnet/aspire@v9.4.1...v9.4.2). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vitor M <[email protected]>
This was referenced Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10934 to release/9.4
/cc @sebastienros
Customer Impact
Users can't resolve the model if the resource and model names don't match.
Testing
Unit testing and manual testing.
Deployed from the dashboard and using azd.
Risk
Low.
Regression?
No, new feature in 9.4